Skip to content

update sample for phase-2 HLT timing tests#48253

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
cms-ngt-hlt:mm_update_sample_for_ph2_timing
Jun 5, 2025
Merged

update sample for phase-2 HLT timing tests#48253
cmsbuild merged 1 commit intocms-sw:masterfrom
cms-ngt-hlt:mm_update_sample_for_ph2_timing

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented Jun 5, 2025

PR description:

Title says it all, needed by #48246 (see #48246 (comment))

PR validation:

None, it will have to be tested in the PR

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not meant to be backported.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 5, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 5, 2025

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 5, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here


FOLDER_FILES="/data/user/${USER}/"
DATASET="/RelValTTbar_14TeV/CMSSW_14_1_0_pre6-PU_141X_mcRun4_realistic_v1_STD_2026D110_PU-v3/GEN-SIM-DIGI-RAW"
DATASET="/RelValTTbar_14TeV/CMSSW_15_1_0_pre3-PU_150X_mcRun4_realistic_v1_STD_Run4D110_PU-v1/GEN-SIM-DIGI-RAW"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar is this going to be enough for the bot to cache the new files?

@rovere FYI

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar is this going to be enough for the bot to cache the new files?

yes if PR unit test has managed to access any file from this dataset then bot will be able to cache it

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Jun 5, 2025

test parameters:

  • enable = hlt_p2_timing

@smuzaffar
Copy link
Copy Markdown
Contributor

please test

lets start the tests. If unit tests failed to find the new data set then I will try a manual search

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Jun 5, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 5, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5196b6/46557/summary.html
COMMIT: 37a2b44
CMSSW: CMSSW_15_1_X_2025-06-04-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48253/46557/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4048495
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4048456
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Jun 5, 2025

Apparently updating the sample does increase timing:

  • Timing menu:
This PR Baseline
timing_PR timing_baseline

so we go from 8.39 ev/s to 9.0 ev/s, i.e. a +7% increase in timing!

  • NGT scouting:
This PR Baseline
NG_PR NGT_baseline

so we go from 10.83 ev/s to 11.7 ev/s, i.e. a +8% increase in timing!

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Jun 5, 2025

+hlt

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 5, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 9b52ede into cms-sw:master Jun 5, 2025
12 checks passed
@mmusich mmusich deleted the mm_update_sample_for_ph2_timing branch June 5, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants