Skip to content

Keep proper file extension for ALCAReAlCaHLTHGComb workflow#48257

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
Dr15Jones:fixFileExtensionALCA
Jun 12, 2025
Merged

Keep proper file extension for ALCAReAlCaHLTHGComb workflow#48257
cmsbuild merged 1 commit intocms-sw:masterfrom
Dr15Jones:fixFileExtensionALCA

Conversation

@Dr15Jones
Copy link
Copy Markdown
Contributor

@Dr15Jones Dr15Jones commented Jun 5, 2025

PR description:

This is one component for fixing the workflow in the RNTUPLE builds. The other component has to go into the RNTUPLE only build.

PR validation:

Tested in RNTUPLE build and properly sets file extension.

resolves cms-sw/framework-team#1421

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 5, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 5, 2025

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 5, 2025

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 5, 2025

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-657069/46570/summary.html
COMMIT: 50a81cc
CMSSW: CMSSW_15_1_X_2025-06-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48257/46570/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-657069/46570/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-657069/46570/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4048495
  • DQMHistoTests: Total failures: 27
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4048448
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 ping

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented Jun 10, 2025

+Upgrade

@AdrianoDee
Copy link
Copy Markdown
Contributor

+pdmv

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 4686af5 into cms-sw:master Jun 12, 2025
10 checks passed
@Dr15Jones Dr15Jones deleted the fixFileExtensionALCA branch June 12, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve file extension in workflow 1002.5

5 participants