Fix crashes in HGCAL DIGI+ with v19 geometry

[pfs]

PR description:

The new v19 geometry causes crashes in the DIGI, L1 and RECO steps [1] due to the introduction of new sensor types for HGCAL [2]. This has been traced to be caused by fixed size arrays and hardcoded constants. In this PR we fix several of these instances with the goal of unblocking the usage of v19 geometry

[1] #47968
[2] https://indico.cern.ch/event/1529650/contributions/6435641/attachments/3039546/5368577/Phase2-Talk146.pdf

PR validation:

Locally we have validated this so far with

runTheMatrix.py -l 34034.0

At the time of pushing the PR we haven't however finished our tests and we would like to profit from the centralized CI/CD to spot additional uncovered failures.

Tagging: @felicepantaleo @waredjeb @jbsauvan @EmyrClement @indra-ehep @bsunanda (sorry if already tagged by the labels assigned to PR)

[cmsbuild]

cms-bot internal usage

[pfs]

assign hgcal-dpg

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48287/45132

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalCalo/HGCalRecAlgos/src/RecHitTools.cc modified in PR(s): TICL-barrel: run CLUE in the barrel calorimeters and first workflows #47859

[cmsbuild]

New categories assigned: hgcal-dpg

@cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Pull Request was created by @pfs for master.

It involves the following packages:

• DataFormats/ForwardDetId (simulation, upgrade)
• HLTrigger/Configuration (hlt)
• L1Trigger/L1THGCal (l1, upgrade)
• RecoLocalCalo/HGCalRecAlgos (reconstruction, upgrade)
• RecoLocalCalo/HGCalRecProducers (reconstruction, upgrade)
• SimCalorimetry/HGCalSimProducers (simulation, upgrade)

@BenjaminRS, @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @cseez, @felicepantaleo, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @pfs, @quinnanm, @rovere, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @SohamBhattacharya, @VourMa, @amarini, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @edjtscott, @fabiocos, @felicepantaleo, @hatakeyamak, @jbsauvan, @lecriste, @lgray, @martinamalberti, @missirol, @mmusich, @rchatter, @rovere, @salimcerci, @sameasy, @sethzenz, @thomreis, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[pfs]

please test

[pfs]

please test workflow 34034.0

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 72KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adaf04/46636/summary.html
COMMIT: 3abb9a2
CMSSW: CMSSW_15_1_X_2025-06-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48287/46636/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 29634.75A fatal system signal has occurred: abort signal
• 29834.999A fatal system signal has occurred: abort signal
• 24834.911A fatal system signal has occurred: abort signal

Expand to see more relval errors ...

• 29700.0
• 34034.0
• 29696.0
• 29634.911
• 29634.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48287/45139

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalCalo/HGCalRecAlgos/src/RecHitTools.cc modified in PR(s): TICL-barrel: run CLUE in the barrel calorimeters and first workflows #47859

[cmsbuild]

Pull request #48287 was updated. @BenjaminRS, @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @cseez, @felicepantaleo, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @pfs, @quinnanm, @rovere, @srimanob, @subirsarkar can you please check and sign again.

[mmusich]

@pfs this PR hits assertions in many phase-2 workflows:

cmsRun: src/RecoLocalCalo/HGCalRecProducers/plugins/HGCalRecHitWorkerSimple.cc:82: HGCalRecHitWorkerSimple::HGCalRecHitWorkerSimple(const edm::ParameterSet&, edm::ConsumesCollector): Assertion `hgcEE_cce_.size() == hgcEE_fCPerMIP_.size()' failed.

[pfs]

please test with #48292

[pfs]

@pfs this PR hits assertions in many phase-2 workflows:

cmsRun: src/RecoLocalCalo/HGCalRecProducers/plugins/HGCalRecHitWorkerSimple.cc:82: HGCalRecHitWorkerSimple::HGCalRecHitWorkerSimple(const edm::ParameterSet&, edm::ConsumesCollector): Assertion `hgcEE_cce_.size() == hgcEE_fCPerMIP_.size()' failed.

yes thanks - we're working on it, that's somehow what I mentioned in the introduction that we only tested this up to a certain stage.

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adaf04/46663/summary.html
COMMIT: f046bfb
CMSSW: CMSSW_15_1_X_2025-06-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48287/46663/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 29634.75A fatal system signal has occurred: abort signal
• 29834.999A fatal system signal has occurred: abort signal
• 24834.911A fatal system signal has occurred: abort signal

Expand to see more relval errors ...

• 29700.0
• 29696.0
• 29634.911
• 29634.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48287/45172

• There are other open Pull requests which might conflict with changes you have proposed:
  • File HLTrigger/Configuration/python/HLT_75e33/psets/HGCAL_chargeCollectionEfficiencies_cfi.py modified in PR(s): Fix crashes in HGCAL HLT/RECO with v19 geometry #48303
  • File HLTrigger/Configuration/python/HLT_75e33/psets/HGCAL_noise_fC_cfi.py modified in PR(s): Fix crashes in HGCAL HLT/RECO with v19 geometry #48303
  • File L1Trigger/L1THGCal/python/l1tHGCalVFEProducer_cfi.py modified in PR(s): Fix crashes in HGCAL HLT/RECO with v19 geometry #48303
  • File L1Trigger/L1THGCal/src/veryfrontend/HGCalVFESummationImpl.cc modified in PR(s): Fix crashes in HGCAL HLT/RECO with v19 geometry #48303
  • File RecoLocalCalo/HGCalRecAlgos/src/RecHitTools.cc modified in PR(s): TICL-barrel: run CLUE in the barrel calorimeters and first workflows #47859
  • File SimCalorimetry/HGCalSimProducers/interface/HGCDigitizerBase.h modified in PR(s): Fix crashes in HGCAL HLT/RECO with v19 geometry #48303
  • File SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py modified in PR(s): Fix crashes in HGCAL HLT/RECO with v19 geometry #48303

[cmsbuild]

Pull request #48287 was updated. @BenjaminRS, @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @cseez, @felicepantaleo, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @pfs, @quinnanm, @rovere, @srimanob, @subirsarkar can you please check and sign again.

[pfs]

I'm cancelling this one as #48303 has merged the original branch to avoid conflicts in the CI. Thanks