Add access to dEdx error

[stahlleiton]

PR description:

This PR provides the option to access the error of the dEdx estimate derived from the loglikelihood dEdx estimator. In addition, it decouples the loglikelihood dEdx estimator from the UPC eras, by using a dedicated era modifier dedx_lfit.

@mandrenguyen @sikler

PR validation:

tested with 141.901,141.902,142.901,142.902,142.903,143.901,143.902,143.911,143.912,143.921

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48635/45611

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Configuration/Eras/python/Era_Run3_2025_OXY_cff.py modified in PR(s): To correct L1T Zero Suppression we move ZDC to position 54 and moves ZS up to 52 and 53 #48633
  • File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): To correct L1T Zero Suppression we move ZDC to position 54 and moves ZS up to 52 and 53 #48633
  • File RecoTracker/DeDx/python/dedxEstimators_cff.py modified in PR(s): To correct L1T Zero Suppression we move ZDC to position 54 and moves ZS up to 52 and 53 #48633

[cmsbuild]

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

• Configuration/Eras (operations)
• DataFormats/TrackReco (reconstruction)
• FastSimulation/SimplifiedGeometryPropagator (fastsim)
• PhysicsTools/PatAlgos (xpog, reconstruction)
• RecoTracker/Configuration (reconstruction)
• RecoTracker/DeDx (reconstruction)

@antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @ftorrresd, @hqucms, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @rappoccio, @ssekmen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @GiacomoSguazzoni, @Martin-Grunewald, @Ming-Yan, @Senphy, @VinInn, @VourMa, @ahinzmann, @andrzejnovak, @azotz, @castaned, @dgulhan, @fabiocos, @felicepantaleo, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @makortel, @mariadalfonso, @matt-komm, @mbluj, @missirol, @mmarionncern, @mmusich, @mtosi, @nhanvtran, @pavlo-kashko, @philippgadow, @rappoccio, @rovere, @sbein, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48635/45612

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Configuration/Eras/python/Era_Run3_2025_OXY_cff.py modified in PR(s): To correct L1T Zero Suppression we move ZDC to position 54 and moves ZS up to 52 and 53 #48633
  • File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): To correct L1T Zero Suppression we move ZDC to position 54 and moves ZS up to 52 and 53 #48633
  • File RecoTracker/DeDx/python/dedxEstimators_cff.py modified in PR(s): To correct L1T Zero Suppression we move ZDC to position 54 and moves ZS up to 52 and 53 #48633

[cmsbuild]

Pull request #48635 was updated. @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @ftorrresd, @hqucms, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @rappoccio, @ssekmen can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ad13/47404/summary.html
COMMIT: 75ab7d5
CMSSW: CMSSW_15_1_X_2025-07-27-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48635/47404/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 159.01159.01_HydjetQ_reminiaodPbPb2022_INPUT/step2_HydjetQ_reminiaodPbPb2022_INPUT.log

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 4305375
• DQMHistoTests: Total failures: 125
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4305230
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 223 log files, 194 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[stahlleiton]

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 Could you review and sign, please?

[Moanwar]

+Upgrade

[kpedro88]

+fastsim

[ftorrresd]

+xpog

[stahlleiton]

@cms-sw/pdmv-l2 Could you review and sign, please?

[AdrianoDee]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[makortel]

Workflows 138.1 and 138.2 fail with

----- Begin Fatal Exception 07-Aug-2025 16:57:40 CEST-----------------------
An exception of category 'FileReadError' occurred while
   [0] Processing  Event run: 343498 lumi: 775 event: 12655182 stream: 0
   [1] Running path 'RECOoutput_step'
   [2] Prefetching for module PoolOutputModule/'RECOoutput'
   [3] While reading from source edm::ValueMap<reco::DeDxData> dedxHarmonic2CosmicTF '' RECO
   [4] Reading branch recoDeDxDataedmValueMap_dedxHarmonic2CosmicTF__RECO.
   Additional Info:
      [a] Fatal Root Error: @SUB=TBufferFile::CheckByteCount
object of class vector<reco::DeDxData> read too many bytes: 24 instead of 20

----- End Fatal Exception -------------------------------------------------

The input data is from Commissioning2021/ExpressCosmics, so presumably they could be fixed with IOPool/Input/fixReading_12_4_X_Files.fixReading_12_4_X_Files. @stahlleiton would you be able to provide a fix?

[stahlleiton]

Workflows 138.1 and 138.2 fail with

----- Begin Fatal Exception 07-Aug-2025 16:57:40 CEST-----------------------
An exception of category 'FileReadError' occurred while
   [0] Processing  Event run: 343498 lumi: 775 event: 12655182 stream: 0
   [1] Running path 'RECOoutput_step'
   [2] Prefetching for module PoolOutputModule/'RECOoutput'
   [3] While reading from source edm::ValueMap<reco::DeDxData> dedxHarmonic2CosmicTF '' RECO
   [4] Reading branch recoDeDxDataedmValueMap_dedxHarmonic2CosmicTF__RECO.
   Additional Info:
      [a] Fatal Root Error: @SUB=TBufferFile::CheckByteCount
object of class vector<reco::DeDxData> read too many bytes: 24 instead of 20

----- End Fatal Exception -------------------------------------------------

The input data is from Commissioning2021/ExpressCosmics, so presumably they could be fixed with IOPool/Input/fixReading_12_4_X_Files.fixReading_12_4_X_Files. @stahlleiton would you be able to provide a fix?

Here is the PR: #48697

[makortel]

Thanks!