Raise ECAL thresholds for beam splashes#48663
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48663/45679
|
|
A new Pull Request was created by @stahlleiton for master. It involves the following packages:
@AdrianoDee, @Moanwar, @antoniovilela, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @jfernan2, @mandrenguyen, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| # This modifier is for beam splash | ||
| beamSplash = cms.Modifier() |
There was a problem hiding this comment.
is this meant to be picked up by Tier0 during splashes?
If so, how do you envisage it, lacking an appropriate scenario?
There was a problem hiding this comment.
That is a good question. I made this PR in an attempt to address the issue reported on relval 138.3 . However I am not sure what would be the best strategy regarding its use in T0.
|
please test workflow 138.3 for CMSSW_15_1_ASAN_X |
|
-1 Failed Tests: RelVals RelVals
|
|
Not sure if the error in the tests are related to this PR |
No, it occurs also in the IBs (reported in #47170) |
|
@cmsbuild, please test Let's run standard tests anyway |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
+1 |
|
+Upgrade |
|
@cms-sw/pdmv-l2 Could you review and sign, please? |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR raises the ECAL thresholds for beam splashes as suggested in #37362 (comment) , in an attempt to solve the issue reported in #37362 .
PR validation:
Tested with workflow 138.3
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: