Remove Run2 procModifier from Run3 ReMINI relval workflows and fix BTV MINIAOD DQM#48686
Merged
cmsbuild merged 2 commits intocms-sw:masterfrom Aug 20, 2025
Merged
Conversation
Contributor
|
cms-bot internal usage |
Contributor
Author
|
enable nano |
Contributor
Author
|
please test |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48686/45705
|
cmsbuild
added
tests-started
code-checks-approved
and removed
tests-pending
code-checks-pending
labels
Contributor
|
A new Pull Request was created by @hqucms for master. It involves the following packages:
@AdrianoDee, @Moanwar, @antoniovagnerini, @ctarricone, @DickyChant, @miquork, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
+1 Size: This PR adds an extra 68KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
This was referenced Aug 6, 2025
Contributor
|
+pdmv |
|
+dqm |
Contributor
|
+Upgrade |
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This PR removes the
run2_miniAOD_UL_preSummer20procModifier, which leaked into the Run3 ReMINI relval workflows (2500.2601,2500.2701) when cloning the relval steps from Run2_UL configs.When fixing this, it revealed an outdated configuration in the BTV MINIAOD DQM, which by default includes the
bTagSVDQMmodule that relies onpfSecondaryVertexTagInfos. However, with the removal of CSVv2 from MINIAOD, thepfSecondaryVertexTagInfoscollection is no longer produced in the MINIAOD step, so thebTagSVDQMmodule would crash.This problem has not been revealed so far because in
bTagMiniDQM_cff.py, theminiAOD_skip_trackExtras(part ofrun2_miniAOD_UL_preSummer20) modifier was used to exclude thebTagSVDQMmodule. However, since the default MINIAOD no longer haspfSecondaryVertexTagInfos, thebTagSVDQMmodule should also be removed in the default configuration too.PR validation:
Tested with
runTheMatrix.py -w nano --ibeos -l 2500.2601,2500.2701.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 150X.