Skip to content

Raise ECAL thresholds for beam splashes #48663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Sep 2, 2025
Merged

Raise ECAL thresholds for beam splashes #48663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Configuration/ProcessModifiers/python/beamSplash_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import FWCore.ParameterSet.Config as cms

# This modifier is for beam splash
beamSplash = cms.Modifier()
Copy link
Copy Markdown
Contributor

@mmusich mmusich Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this meant to be picked up by Tier0 during splashes?
If so, how do you envisage it, lacking an appropriate scenario?

Copy link
Copy Markdown
Contributor Author

@stahlleiton stahlleiton Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good question. I made this PR in an attempt to address the issue reported on relval 138.3 . However I am not sure what would be the best strategy regarding its use in T0.

1 change: 1 addition & 0 deletions Configuration/PyReleaseValidation/python/relval_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2906,6 +2906,7 @@ def lhegensim2018ml(fragment,howMuch):
steps['RECODR3_2025_OXY_SKIMIONPHYSICS0']=merge([{'--era':'Run3_2025_OXY', '-s':'RAW2DIGI,L1Reco,RECO,SKIM:%s,PAT,DQM:@commonFakeHLT+@standardDQMFakeHLT'%(autoSkim['IonPhysics0'])},steps['RECODR3_2025_HIN']])

steps['RECODR3Splash']=merge([{'-n': 2,
'--procModifiers': 'beamSplash',
'-s': 'RAW2DIGI,L1Reco,RECO,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQMFakeHLT+@miniAODDQM'
},steps['RECODR3']])

Expand Down
5 changes: 5 additions & 0 deletions RecoParticleFlow/PFClusterProducer/python/particleFlowClusterECALUncorrected_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@
),
nNeighbours = cms.int32(8),
)
from Configuration.ProcessModifiers.beamSplash_cff import beamSplash
beamSplash.toModify(_localMaxSeeds_ECAL.thresholdsByDetector[0], seedingThreshold = 100, seedingThresholdPt = 20)
beamSplash.toModify(_localMaxSeeds_ECAL.thresholdsByDetector[1], seedingThreshold = 100, seedingThresholdPt = 20)

# topo clusterizer
_topoClusterizer_ECAL = cms.PSet(
Expand All @@ -77,6 +80,8 @@
),
useCornerCells = cms.bool(True)
)
beamSplash.toModify(_topoClusterizer_ECAL.thresholdsByDetector[0], gatheringThreshold = 90)
beamSplash.toModify(_topoClusterizer_ECAL.thresholdsByDetector[1], gatheringThreshold = 90)

#position calculations
_positionCalcECAL_all_nodepth = cms.PSet(
Expand Down