Skip to content

Enabling SiPixel good edge algorithm from 2025 onward#48796

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
CMSTrackerDPG:GoodEdge_on_2025-15_1_X
Aug 26, 2025
Merged

Enabling SiPixel good edge algorithm from 2025 onward#48796
cmsbuild merged 1 commit intocms-sw:masterfrom
CMSTrackerDPG:GoodEdge_on_2025-15_1_X

Conversation

@ferencek
Copy link
Copy Markdown
Contributor

@ferencek ferencek commented Aug 25, 2025

PR description:

This PR enables from 2025 onward the SiPixel good edge algorithm introduced in #48356.

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW_15_0_X

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Aug 25, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @ferencek for master.

It involves the following packages:

  • Configuration/Eras (operations)

@cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Aug 26, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1b2c5/47857/summary.html
COMMIT: 571cfb3
CMSSW: CMSSW_15_1_X_2025-08-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48796/47857/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@slava77
Copy link
Copy Markdown
Contributor

slava77 commented Aug 26, 2025

This PR enabled from 2025 onward the SiPixel good edge algorithm introduced in #48356.

was it shown already that this change does harm to 2024 or earlier data?
or is the reason to not enable earlier coming from some other reasons?

@ferencek
Copy link
Copy Markdown
Contributor Author

This PR enabled from 2025 onward the SiPixel good edge algorithm introduced in #48356.

was it shown already that this change does harm to 2024 or earlier data? or is the reason to not enable earlier coming from some other reasons?

The algorithm itself was developed and tested on end of 2024 data. The original presentation is here https://indico.cern.ch/event/1505984/#36-update-on-pixel-cpe One thing to note is that the code update needs to be accompanied by appropriately derived calibrations. So the algorithm would certainly be beneficial for already collected 2025 and end of 2024 data (roughly Run2024E and onward) but this would imply doing a re-reco with updated code and calibrations. This PR primarily targets deployment in the prompt reco which is why it is for now restricted to Run3_2025.

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1
As discussed at the ORP today, the strategy will be to build the corresponding backport into a patch that can be replayed pending validation. In case the validation fails we can eventually revert, if necessary.

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 20bf2f2 into cms-sw:master Aug 26, 2025
10 checks passed
@ferencek ferencek deleted the GoodEdge_on_2025-15_1_X branch August 27, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants