Determine non-process name lookups at begin job#48807
Merged
cmsbuild merged 13 commits intocms-sw:masterfrom Sep 16, 2025
Merged
Determine non-process name lookups at begin job#48807cmsbuild merged 13 commits intocms-sw:masterfrom
cmsbuild merged 13 commits intocms-sw:masterfrom
Conversation
Contributor
Author
|
please test |
Contributor
|
cms-bot internal usage |
Contributor
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48807/45913
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
tests-pending
code-checks-pending
and removed
code-checks-pending
tests-started
code-checks-rejected
labels
Contributor
Author
|
please test |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48807/45914
|
Contributor
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-started
code-checks-approved
labels
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48807/45915
|
An empty ROOT files contains no ProcessHistory which causes problems when filling the ProductRegistry at construction time. Now skip empty files until we find a file with data.
Instead of dynamically determining what data product to get at Run/LuminosityBlock/Event transition time, the data product to get is now determined at begin job time. This is done for no-process and the skip current process cases.
Only call produces and consumes if the data products the module want appear to be in the job. This solves the case where the module has been added to a job just on the remote possibility it might be needed but infact the values which are actually wanted come from the source.
The MixingModule does not use consumes when getting data from the mixing files.
Contributor
Author
|
please test |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48807/46046
|
Contributor
Contributor
|
@cmsbuild, please test |
Contributor
|
unhold |
Contributor
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
Contributor
|
@cms-sw/simulation-l2 @cms-sw/generators-l2 Could you please review and sign? Thanks! |
Contributor
|
+simulation |
Contributor
Author
|
@cms-sw/generators-l2 please sign as this is holding up further developments |
Contributor
|
+generators |
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
Author
|
@cms-sw/orp-l2 if this could get merged in sooner rather than later it would make it possible to start fixing other PRs which will likely fail to merge because of changing the same files. |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
When a specific process name is not given during the
consumescall, the system now finds the best matching process to use at begin job time. If at transition processing time the data product matched is not found, no further matches are attempted.Internally the ProductResolverIndexHelper now holds an entry to lookup which ProductResolver to call if one requests to skip current process . This is now also determined at begin job time rather than at run time.
PR validation:
Code compiles and all framework unit tests (after modification) pass.
resolves cms-sw/framework-team#1522