Skip to content

Moved Pool based tests from FWCore to IOPool#48908

Merged
cmsbuild merged 25 commits intocms-sw:masterfrom
Dr15Jones:movePoolTests
Sep 17, 2025
Merged

Moved Pool based tests from FWCore to IOPool#48908
cmsbuild merged 25 commits intocms-sw:masterfrom
Dr15Jones:movePoolTests

Conversation

@Dr15Jones
Copy link
Copy Markdown
Contributor

@Dr15Jones Dr15Jones commented Sep 12, 2025

PR description:

This moves all tests making use of PoolSource and PoolOutputModule from most of FWCore (FWCore/FWLite still has such usage) to IOPool/Tests. This is in anticipation of eventually migrating from ROOT TTree based storage format to ROOT RNTuple storage. The RNTuple based tests will be in a package specific to RNTuple.

PR validation:

Code compiles and the Framework unit tests pass.

resolves cms-sw/framework-team#1560

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 12, 2025

cms-bot internal usage

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

hold
this should be integrated after #48807 which touched some of the same files.

@cmsbuild cmsbuild added the hold label Sep 12, 2025
@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48908/46071

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/Integration (core)
  • FWCore/MessageService (core)
  • FWCore/Modules (core)
  • FWCore/ParameterSet (core)
  • FWCore/PythonParameterSet (core)
  • IOPool/Tests (****)

The following packages do not have a category, yet:

IOPool/Tests
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 228KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-675764/48090/summary.html
COMMIT: 3f54c1a
CMSSW: CMSSW_16_0_X_2025-09-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48908/48090/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48908/46072

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #48908 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

This was rebased onto master after the inclusion of #48807

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48908/46096

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #48908 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 224KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-675764/48162/summary.html
COMMIT: d36ff43
CMSSW: CMSSW_16_0_X_2025-09-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48908/48162/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3978581
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3978558
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 210 log files, 180 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor

+core

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit 41ffb8e into cms-sw:master Sep 17, 2025
10 checks passed
@Dr15Jones Dr15Jones deleted the movePoolTests branch September 17, 2025 14:58
makortel added a commit to makortel/cmssw that referenced this pull request Dec 19, 2025
This was moved to IOPool/Tests/test in cms-sw#48908

I checked the files have equivalent content.
chrishanw pushed a commit to chrishanw/cmssw that referenced this pull request Jan 6, 2026
This was moved to IOPool/Tests/test in cms-sw#48908

I checked the files have equivalent content.
chrishanw pushed a commit to chrishanw/cmssw that referenced this pull request Jan 14, 2026
This was moved to IOPool/Tests/test in cms-sw#48908

I checked the files have equivalent content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move IOPool-specific tests from FWCore/* to IOPool/Tests/test

4 participants