Moved Pool based tests from FWCore to IOPool#48908
Conversation
|
cms-bot internal usage |
|
hold |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48908/46071
|
|
Pull request has been put on hold by @Dr15Jones |
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
The following packages do not have a category, yet: IOPool/Tests @Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used: See details on the summary page. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48908/46072
|
|
Pull request #48908 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again. |
|
This was rebased onto master after the inclusion of #48807 |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48908/46096
|
|
Pull request #48908 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again. |
|
+1 Size: This PR adds an extra 224KB to repository Comparison SummarySummary:
|
|
+core |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This was moved to IOPool/Tests/test in cms-sw#48908 I checked the files have equivalent content.
This was moved to IOPool/Tests/test in cms-sw#48908 I checked the files have equivalent content.
This was moved to IOPool/Tests/test in cms-sw#48908 I checked the files have equivalent content.
PR description:
This moves all tests making use of PoolSource and PoolOutputModule from most of FWCore (FWCore/FWLite still has such usage) to IOPool/Tests. This is in anticipation of eventually migrating from ROOT TTree based storage format to ROOT RNTuple storage. The RNTuple based tests will be in a package specific to RNTuple.
PR validation:
Code compiles and the Framework unit tests pass.
resolves cms-sw/framework-team#1560