Skip to content

Remove SwitchProducer and ConditionalTask from the framework#48816

Merged
cmsbuild merged 5 commits intocms-sw:masterfrom
makortel:removeSwitchProducer
Sep 17, 2025
Merged

Remove SwitchProducer and ConditionalTask from the framework#48816
cmsbuild merged 5 commits intocms-sw:masterfrom
makortel:removeSwitchProducer

Conversation

@makortel
Copy link
Copy Markdown
Contributor

PR description:

Following #48768 this PR removes SwitchProducer and ConditionalTask from the framework (as announced in https://indico.cern.ch/event/1473390/#8-future-framework-development and in https://cms-talk.web.cern.ch/t/removal-of-subprocess-feature/117449).

Intended for 16_0_X. Conflicts with #48807, and is probably easiest to be rebased after that gets merged (than vice versa).

Resolves cms-sw/framework-team#1515

PR validation:

Framework unit tests succeed.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Aug 28, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48816/45931

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Aug 28, 2025

@makortel, can you consider adding the unit tests of HLTrigger/Configuration to the PR tests just to be on the safe side?

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/Common (core)
  • DataFormats/Provenance (core)
  • FWCore/Framework (core)
  • FWCore/Integration (core)
  • FWCore/Modules (core)
  • FWCore/ParameterSet (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Copy Markdown
Contributor Author

can you consider adding the unit tests of HLTrigger/Configuration to the PR tests just to be on the safe side?

Sure, thanks for the suggestion.

@makortel
Copy link
Copy Markdown
Contributor Author

test parameters:

  • addpkg = HLTrigger/Configuration

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@wddgit
Copy link
Copy Markdown
Contributor

wddgit commented Aug 28, 2025

In the title did you mean "and" instead of "as"?

@makortel makortel changed the title Remove SwitchProducer as ConditionalTask from the framework Remove SwitchProducer and ConditionalTask from the framework Aug 28, 2025
@makortel
Copy link
Copy Markdown
Contributor Author

In the title did you mean "and" instead of "as"?

Yes, thank you for catching.

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: Build
Size: This PR adds an extra 188KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3576dd/47896/summary.html
COMMIT: 9487780
CMSSW: CMSSW_15_1_X_2025-08-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48816/47896/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin src/Validation/GlobalRecHits/src/GlobalRecHitsProducer.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DGNU_GCC -DG4V9 -D__STDC_LIMIT_MACROS -D__STDC_FORMAT_MACROS -DGNU_GCC -DG4V9 -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-08-28-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-08-28-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-08-28-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/dd4hep/v01-29-00-20154c7d2051779000c69dd6f1e43dab/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/alpaka/1.2.0-ab54b9441c1c5ea12d3b50618a416376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/classlib/3.1.3-2827e9dbeb7dd2aced5a46b8a966dfab/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/geant4/11.2.2-7ace3faa1f613dee2af01c298c5e704c/include/Geant4 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/geant4/11.2.2-7ace3faa1f613dee2af01c298c5e704c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/boost/1.80.0-9fe8bbbc2e1ad17df3cd25532722ba62/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/expat/2.4.8-b093687a482bf386f8f8c236c5b2efa2/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/hepmc/2.06.10-262d73524c32528e87adc31a98f68d52/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/hls/2025.05-4da036171b10090d7d21e15c49bb27a1/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/protobuf/3.21.9-1126508a53768c90e66f6bf1821ac03a/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/lcg/root/6.32.13-be42ecc3174fc32011283ebcc8be2a76/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/tbb/v2022.0.0-d2baf29793e68d7b624be49d552519ec/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/utm/utm_0.13.0-6d26f5cab0cf4012a8d536162a10d2e4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/cms/vdt/0.4.3-f008bd09702a81e8a062bbef698ed3af/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/vecgeom/v1.2.11-db93479c7d2200c4de9dccc28799f670/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/vecgeom/v1.2.11-db93479c7d2200c4de9dccc28799f670/include/VecGeom -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/hepmc3/3.2.7-f10dce5b16f0246f8cac8378933b9681/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/tinyxml2/6.2.0-a0ad3950415fa3138d99b7da42eb4c9f/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -ftls-model=global-dynamic -pthread -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/Validation/GlobalRecHits/src/ValidationGlobalRecHits/GlobalRecHitsProducer.cc.d src/Validation/GlobalRecHits/src/GlobalRecHitsProducer.cc -o tmp/el8_amd64_gcc12/src/Validation/GlobalRecHits/src/ValidationGlobalRecHits/GlobalRecHitsProducer.cc.o
>> Compiling edm plugin src/Validation/GlobalRecHits/src/SealModule.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DGNU_GCC -DG4V9 -D__STDC_LIMIT_MACROS -D__STDC_FORMAT_MACROS -DGNU_GCC -DG4V9 -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-08-28-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-08-28-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-08-28-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/dd4hep/v01-29-00-20154c7d2051779000c69dd6f1e43dab/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/alpaka/1.2.0-ab54b9441c1c5ea12d3b50618a416376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/classlib/3.1.3-2827e9dbeb7dd2aced5a46b8a966dfab/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/geant4/11.2.2-7ace3faa1f613dee2af01c298c5e704c/include/Geant4 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/geant4/11.2.2-7ace3faa1f613dee2af01c298c5e704c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/boost/1.80.0-9fe8bbbc2e1ad17df3cd25532722ba62/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/expat/2.4.8-b093687a482bf386f8f8c236c5b2efa2/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/hepmc/2.06.10-262d73524c32528e87adc31a98f68d52/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/hls/2025.05-4da036171b10090d7d21e15c49bb27a1/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/protobuf/3.21.9-1126508a53768c90e66f6bf1821ac03a/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/lcg/root/6.32.13-be42ecc3174fc32011283ebcc8be2a76/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/tbb/v2022.0.0-d2baf29793e68d7b624be49d552519ec/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/utm/utm_0.13.0-6d26f5cab0cf4012a8d536162a10d2e4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/cms/vdt/0.4.3-f008bd09702a81e8a062bbef698ed3af/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/vecgeom/v1.2.11-db93479c7d2200c4de9dccc28799f670/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/vecgeom/v1.2.11-db93479c7d2200c4de9dccc28799f670/include/VecGeom -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/hepmc3/3.2.7-f10dce5b16f0246f8cac8378933b9681/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02904/el8_amd64_gcc12/external/tinyxml2/6.2.0-a0ad3950415fa3138d99b7da42eb4c9f/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -ftls-model=global-dynamic -pthread -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/Validation/GlobalRecHits/src/ValidationGlobalRecHits/SealModule.cc.d src/Validation/GlobalRecHits/src/SealModule.cc -o tmp/el8_amd64_gcc12/src/Validation/GlobalRecHits/src/ValidationGlobalRecHits/SealModule.cc.o
src/Validation/GlobalRecHits/src/GlobalRecHitsAnalyzer.cc: In lambda function:
src/Validation/GlobalRecHits/src/GlobalRecHitsAnalyzer.cc:41:12: error: 'const edm::ProductDescription' {aka 'const class edm::BranchDescription'} has no member named 'isAnyAlias'; did you mean 'isAlias'?
   41 |     if (bd.isAnyAlias())
      |            ^~~~~~~~~~
      |            isAlias
gmake: *** [tmp/el8_amd64_gcc12/src/Validation/GlobalRecHits/src/ValidationGlobalRecHits/GlobalRecHitsAnalyzer.cc.o] Error 1
>> Building edm plugin tmp/el8_amd64_gcc12/src/Validation/GlobalRecHits/src/ValidationGlobalRecHits/libValidationGlobalRecHits.so


@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48816/45932

@makortel
Copy link
Copy Markdown
Contributor Author

Rebased on top of CMSSW_16_0_X_2025-09-16-1100 (to resolve a conflict with #48807 that was merged recently)

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48816/46098

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #48816 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3576dd/48170/summary.html
COMMIT: 18495d8
CMSSW: CMSSW_16_0_X_2025-09-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48816/48170/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3978581
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3978558
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 210 log files, 180 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor Author

+core

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link
Copy Markdown

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove SwitchProducer and ConditionalTask from the framework

6 participants