Use the GPU family macros for the ROCm warp size

[fwyzard]

PR description:

Use the GPU family macros instead of the individual GPU macros to define the ROCm warp size.

PR validation:

Tests pass.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49016/46208

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

test parameters:

• enable_tests = gpu
• gpu = amd_w7900,amd_mi300x

[fwyzard]

please test

[fwyzard]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54d638/48322/summary.html
COMMIT: 6970d6c
CMSSW: CMSSW_16_0_X_2025-09-28-2300/el8_amd64_gcc12
Additional Tests: GPU,AMD_MI300X,AMD_W7900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49016/48322/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 2025.0000001DAS Error
• 2024.0030001DAS Error
• 2024.0070001DAS Error

Expand to see more relval errors ...

• 2024.0050001
• 2024.0060001
• 2024.0040001

AMD_W7900 Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 187 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 146188
• DQMHistoTests: Total failures: 33091
• DQMHistoTests: Total nulls: 11
• DQMHistoTests: Total successes: 113086
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 42 log files, 45 edm output root files, 11 DQM output files
• TriggerResults: no differences found

[fwyzard]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54d638/48326/summary.html
COMMIT: 6970d6c
CMSSW: CMSSW_16_0_X_2025-09-28-2300/el8_amd64_gcc12
Additional Tests: GPU,AMD_MI300X,AMD_W7900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49016/48326/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
2024.0050001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3861349
• DQMHistoTests: Total failures: 23
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3861306
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 233 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 146188
• DQMHistoTests: Total failures: 28874
• DQMHistoTests: Total nulls: 9
• DQMHistoTests: Total successes: 117305
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 42 log files, 45 edm output root files, 11 DQM output files
• TriggerResults: no differences found

AMD_W7900 Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 225 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 146188
• DQMHistoTests: Total failures: 26687
• DQMHistoTests: Total nulls: 10
• DQMHistoTests: Total successes: 119491
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 42 log files, 45 edm output root files, 11 DQM output files
• TriggerResults: no differences found

[ftenchini]

+1

[ftenchini]

Actually, what's going on here? It's got both the "tests approved" and "tests started" label.

[fwyzard]

The reason is that the same commit (same branch) is used for this PR and for #48948.

[fwyzard]

But by now the tests should be completed for both PRs, so it looks like the bot got confused 🤔

@iarspider can you check ?

[iarspider]

Checking.

…

On Tue, Sep 30, 2025, 11:12 Andrea Bocci ***@***.***> wrote: *fwyzard* left a comment (cms-sw/cmssw#49016) <#49016 (comment)> But by now the tests should be completed for both PRs, so it looks like the bot got confused 🤔 @iarspider <https://github.com/iarspider> can you check ? — Reply to this email directly, view it on GitHub <#49016 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE3NOVDPYYAMSFYGJS6CRD3VJCQXAVCNFSM6AAAAACHYDAY4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNJQHA3DIOBVGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[iarspider]

There is a bug in the library that cmsbot uses to communicate with github: if there are too many statuses, it will only return first 30, so the bot doesn't see the status that should trigger posting the results. For now, could you please push a dummy (empty) commit to get a new sha and rerun the tests?

[fwyzard]

Ehm... since the tests passed and the PR is fully signed, can we just merge it ?

[iarspider]

Fine with me, but ultimately it's upto @cms-sw/orp-l2 .

[mandrenguyen]

merge