Minor improvements to das-up-to-nevents.py by kpedro88 · Pull Request #49045 · cms-sw/cmssw

kpedro88 · 2025-10-01T22:18:10Z

PR description:

Use a simple regex to accept golden JSON files matching the desired pattern, rather than trying to reject files that don't match the pattern (which requires more maintenance).
Add a more informative error message when the JSON list cannot be populated.

PR validation:

Tested succeeding and failing commands before and after this change and saw intended results.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not intended to be backported unless requested.

cmsbuild · 2025-10-01T22:18:32Z

cms-bot internal usage

kpedro88 · 2025-10-01T22:19:56Z

@AdrianoDee please let me know if I missed anything here

cmsbuild · 2025-10-01T22:20:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49045/46257

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/scripts/das-up-to-nevents.py modified in PR(s): Simplify Data Workflows in Tests (No JSON Check) #49020

cmsbuild · 2025-10-01T22:20:59Z

A new Pull Request was created by @kpedro88 for master.

It involves the following packages:

Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @DickyChant, @Moanwar, @antoniovagnerini, @cmsbuild, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2025-10-01T22:32:05Z

-            json_list = [c for c in json_list if "golden" in c.lower() and "era" not in c.lower() and "cert_c" in c.lower() and "ppref" not in c.lower()]
-            json_list = [[cc for cc in c.split(" ") if cc.lower().startswith("cert_c") and cc.endswith("json")][0] for c in json_list]
+            json_list_full = get_url_clean(cert_url).split("\n")
+        pattern = re.compile("(cert_collisions\d{4}_\d*_\d*_golden.json)$", re.IGNORECASE)


Maybe this regex could be directly cert_collisions\d{4}_\d{6}_\d{6}_golden.json ?

I wasn't sure if we would still be in 6-digit run numbers by the end of the HL-LHC...

AdrianoDee · 2025-10-01T22:33:20Z

@AdrianoDee please let me know if I missed anything here

Thanks for making it cleaner

AdrianoDee · 2025-10-01T22:37:01Z

please test
(to see also if we reproduce the failure)

cmsbuild · 2025-10-02T08:45:14Z

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5b71c/48414/summary.html
COMMIT: 7ae449e
CMSSW: CMSSW_16_0_X_2025-10-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49045/48414/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

2023.0020001DAS Error
2025.0000001DAS Error
2022.0030001DAS Error

Expand to see more relval errors ...

2024.0030001
2024.0010001
2024.0070001
2024.0050001
2025.0010001
2024.0020001
2024.0000001
2024.0060001
2024.0040001

RelVals-INPUT

2023.0000001DAS Error
2023.0020001DAS Error
2022.0010001DAS Error

Expand to see more relval errors ...

2025.0000001
2022.0030001
2024.0030001
2024.0010001
2025.0010001
2024.0070001
2024.0050001
2025.0020001
2023.0010001
2022.0000001
2022.0020001
2024.0020001
2024.0000001
2024.0060001
2024.0040001

cmsbuild · 2025-10-02T16:00:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49045/46269

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/scripts/das-up-to-nevents.py modified in PR(s): Simplify Data Workflows in Tests (No JSON Check) #49020

cmsbuild · 2025-10-02T16:00:47Z

Pull request #49045 was updated. @AdrianoDee, @DickyChant, @Moanwar, @antoniovagnerini, @cmsbuild, @miquork, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild · 2025-10-03T18:42:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49045/46285

cmsbuild · 2025-10-03T18:42:44Z

Pull request #49045 was updated. @AdrianoDee, @DickyChant, @Moanwar, @antoniovagnerini, @cmsbuild, @miquork, @srimanob, @subirsarkar can you please check and sign again.

kpedro88 · 2025-10-03T18:44:30Z

rebased and squashed

kpedro88 · 2025-10-03T18:44:35Z

please test

cmsbuild · 2025-10-03T20:30:58Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5b71c/48451/summary.html
COMMIT: 8ff0b09
CMSSW: CMSSW_16_0_X_2025-10-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49045/48451/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3924791
DQMHistoTests: Total failures: 60
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3924711
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

AdrianoDee · 2025-10-06T15:26:38Z

+pdmv

kpedro88 · 2025-10-07T13:29:20Z

@cms-sw/upgrade-l2 please sign

Moanwar · 2025-10-07T13:30:30Z

+Upgrade

cmsbuild · 2025-10-07T13:30:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

ftenchini · 2025-10-08T08:37:05Z

+1

cmsbuild added this to the CMSSW_16_0_X milestone Oct 1, 2025

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending labels Oct 1, 2025

kpedro88 mentioned this pull request Oct 1, 2025

Bugfixes to TICL-barrel #48565

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 1, 2025

AdrianoDee reviewed Oct 1, 2025

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Oct 1, 2025

cmsbuild added tests-rejected tests-pending code-checks-pending and removed tests-started tests-rejected code-checks-approved labels Oct 2, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 2, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2025

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2025

cmsbuild added tests-approved and removed tests-started labels Oct 3, 2025

cmsbuild added pdmv-approved and removed pdmv-pending labels Oct 6, 2025

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Oct 7, 2025

cmsbuild added orp-approved and removed orp-pending labels Oct 8, 2025

cmsbuild merged commit 38a94c0 into cms-sw:master Oct 8, 2025
10 checks passed

AdrianoDee mentioned this pull request Dec 16, 2025

Removing JENKINS_PREFIX Check from das-up-to-nevents.py #49636

Merged

Conversation

kpedro88 commented Oct 1, 2025

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kpedro88 commented Oct 1, 2025

Uh oh!

cmsbuild commented Oct 1, 2025

Uh oh!

cmsbuild commented Oct 1, 2025

Uh oh!

AdrianoDee Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

kpedro88 Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

AdrianoDee Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

AdrianoDee commented Oct 1, 2025

Uh oh!

AdrianoDee commented Oct 1, 2025

Uh oh!

cmsbuild commented Oct 2, 2025

RelVals

RelVals-INPUT

Uh oh!

cmsbuild commented Oct 2, 2025

Uh oh!

cmsbuild commented Oct 2, 2025

Uh oh!

cmsbuild commented Oct 3, 2025

Uh oh!

cmsbuild commented Oct 3, 2025

Uh oh!

kpedro88 commented Oct 3, 2025

Uh oh!

kpedro88 commented Oct 3, 2025

Uh oh!

cmsbuild commented Oct 3, 2025

Comparison Summary

Uh oh!

AdrianoDee commented Oct 6, 2025

Uh oh!

kpedro88 commented Oct 7, 2025

Uh oh!

Moanwar commented Oct 7, 2025

Uh oh!

cmsbuild commented Oct 7, 2025

Uh oh!

ftenchini commented Oct 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented Oct 1, 2025 •

edited

Loading