Skip to content

Use RNTuple streamer storage for deque and list#49531

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
Dr15Jones:rntupleDequeList
Dec 4, 2025
Merged

Use RNTuple streamer storage for deque and list#49531
cmsbuild merged 1 commit intocms-sw:masterfrom
Dr15Jones:rntupleDequeList

Conversation

@Dr15Jones
Copy link
Copy Markdown
Contributor

PR description:

These are primarily used for testing just to be sure those types can be stored.

PR validation:

Code compiles.

resolves cms-sw/framework-team#1700

These are primarily used for testing just to be sure those types can be stored.
@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 2, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 2, 2025

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 2, 2025

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • DataFormats/StdDictionaries (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 2, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d95e0b/49770/summary.html
COMMIT: fd8b29a
CMSSW: CMSSW_16_0_X_2025-12-02-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49531/49770/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d95e0b/49770/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d95e0b/49770/git-merge-result

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4269233
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 34
  • DQMHistoTests: Total successes: 4269167
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 21053.640000000003 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 16834.0,... ): 0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 16834.0,... ): 0.008 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 34434.0,... ): 3508.916 KiB HLT/Tracking
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 10 / 51 workflows

@makortel
Copy link
Copy Markdown
Contributor

makortel commented Dec 3, 2025

+core

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 3, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 3, 2025

REMINDER @sextonkennedy, @ftenchini, @mandrenguyen: This PR was tested with #49532, please check if they should be merged together

@makortel
Copy link
Copy Markdown
Contributor

makortel commented Dec 3, 2025

This PR was tested with #49532, please check if they should be merged together

There is no need to merge them together, they can be merged separately.

@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit 5d9598a into cms-sw:master Dec 4, 2025
10 checks passed
@Dr15Jones Dr15Jones deleted the rntupleDequeList branch December 10, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address TestRNTupleTempEventHistory failures

4 participants