[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3

[jfernan2]

PR description:

This PR implements recent changes with bug fixes and upgrades in the L1T DT Trigger Phase-2 emulator:

• Fix to DT Digis plugin from Karol Bunkowski ( @kbunkow ) which prevents crashes due to pointers to local variables stored in vectors, and then these vectors (so also the pointers) were used outside those methods

• Removed t0 Phi replacement in theta Digis at the ThetaMatching filter to preserve original t0 for the Barrel Filter objects pairing

• New DataFormat collection for DT Phase Phi-Theta matched pairs L1Phase2MuDTExtPhiThetaPair and its container L1Phase2MuDTExtPhiThetaPairContainer to be used by the Phase2 Barrel Filter

• Create new plugin DTTrigPhase2PairsProd which takes Phi and Theta DT Phase-2 digi Extended collections[1] and creates a new class container of the 4 best closest Phi-Theta digi pairs per DT chamber based on the time-position phase-space distance and ordered by Phi quality. For those cases where there is no Phi/Theta partner, 4 best quality single Phi/Theta digis are saved and counterpart in pair is set to default values of the constructor digi class (quality = -1, positions = 0).
  [1] Requires df_extended>0 in L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc

• Add DT Phase-2 Digi pair production to the standard L1 Trigger sequence

• Add DT Phase-2 Digi and Digi pair collections to the L1 Trigger default Event Content

• General cleaning of the code

Link to the presentation in the Phase-2 L1T Muon Subsystem group meeting on 22/01/2026

PR validation:

Local validation within CMSSW and w.r.t. firmware (w.i.p.)

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47121

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47121/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47121/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/48338

• There are other open Pull requests which might conflict with changes you have proposed:
  • File L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc modified in PR(s): Updates L1T OMTF for Phase 2 #50032

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/48338/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/48338/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/48340

• There are other open Pull requests which might conflict with changes you have proposed:
  • File L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc modified in PR(s): Updates L1T OMTF for Phase 2 #50032

[cmsbuild]

Pull request #49589 was updated. @BenjaminRS, @quinnanm can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e088c/51717/summary.html
COMMIT: 51b6d66
CMSSW: CMSSW_16_1_X_2026-03-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49589/51717/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 54
• DQMHistoTests: Total histograms compared: 4312490
• DQMHistoTests: Total failures: 111
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4312359
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
• Checked 232 log files, 202 edm output root files, 54 DQM output files
• TriggerResults: no differences found

[BenjaminRS]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1