Phase2 Single_Tau_Trigger Path Added by Chihwan-An · Pull Request #49637 · cms-sw/cmssw

Chihwan-An · 2025-12-16T06:35:32Z

Added Single Tau Trigger path for Phase2 , worked with Tau HLT Phase2 development group.

It was tested in miniAOD in CMSSW_15_1_0_pre4 and NanoAOD in CMSSW_16_0_0_pre2 , with Z'to tautau samples.

Trigger Efficiency had 48.7% .

Phase2 Single_Tau_Trigger Path Added #49569 was submitted before.
- MinEta for HLT1PFTau EDFilters has a default value of -1.0, which the config understands it as being -2.1.
Slides are not shared with TSG group yet , shared with Tau HLT phase2 group .

cmsbuild · 2025-12-16T06:36:02Z

cms-bot internal usage

cmsbuild · 2025-12-16T06:37:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/47177

Found files with invalid states:
- HLTrigger/Configuration/python/HLT_75e33/modules/hltPreLooseDeepTauPFTauHPS150L2NNeta2p1_cfi.py:
  - Added: cfc92f4
  - Deleted: 57b17b8

cmsbuild · 2025-12-16T06:37:46Z

A new Pull Request was created by @Chihwan-An for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2025-12-16T07:38:38Z

please test

cmsbuild · 2025-12-16T09:16:51Z

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/49993/summary.html
COMMIT: 57b17b8
CMSSW: CMSSW_16_0_X_2025-12-15-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/49993/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 15 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4280229
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4280200
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

mmusich · 2025-12-16T09:17:47Z

test parameters:

enable = hlt_p2_integration, hlt_p2_timing
workflows = ph2_hlt

mmusich · 2025-12-16T09:17:56Z

@cmsbuild, please test

mmusich · 2025-12-16T17:05:01Z

Hi @Chihwan-An,
the timing tests are not completed, but I see that this PR is already failing one of the relval tests: 34434.758_TTbar_14TeV+Run4D121_HLT75e33TimingTiclBarrel, see log.
Can you try to reproduce locally by executing runTheMatrix.py -l 34434.758 locally and fix the configuration? From the exception message it looks like it should be fixable by re-ordering the modules scheduled in the new path HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1

mmusich · 2025-12-16T17:13:45Z

hold

Slides are not shared with TSG group yet , shared with Tau HLT phase2 group .
the new path should be discussed first in a HLT upgrade meeting @rovere @VourMa FYI

cmsbuild · 2025-12-16T17:14:04Z

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

mmusich · 2025-12-17T08:50:32Z

@smuzaffar the hlt phase2 timing tests doesn't seem to start, can you check what is the problem with it?

smuzaffar · 2025-12-17T09:10:27Z

@mmusich , I see that job started an hour ago (https://cmssdt.cern.ch/jenkins/job/ib-run-pr-hlt_p2_timing/241/console) . It should finish soon

cmsbuild · 2025-12-17T09:10:38Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/49995/summary.html
COMMIT: 57b17b8
CMSSW: CMSSW_16_0_X_2025-12-15-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/49995/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Failed RelVals

34434.758

----- Begin Fatal Exception 16-Dec-2025 11:15:10 CET-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
Dependent module later on Path
  module 'hltParticleFlowRecHitECALUnseeded' depends on 'hltEcalRecHit' which is later on path HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1
----- End Fatal Exception -------------------------------------------------

mmusich · 2026-02-17T14:53:52Z

@Chihwan-An just checking, do you plan to follow-up to the issue above #49637 (comment) ?

Chihwan-An · 2026-02-19T10:40:05Z

@Chihwan-An just checking, do you plan to follow-up to the issue above #49637 (comment) ?

Yes, I am planning to check this within feb.

mmusich · 2026-03-06T13:07:20Z

@Chihwan-An

Yes, I am planning to check this within feb.

just checking in about the status. Thank you.

Chihwan-An · 2026-03-11T09:54:29Z

@cmsbuild, please test

mmusich · 2026-03-11T10:07:09Z

@Chihwan-An you are not allowed to issue new tests. Do you expect things to have changed in the meanwhile?

Chihwan-An · 2026-03-12T02:33:51Z

@mmusich I am trying to fix this ,
checking with runTheMatrix.py -l 34434.758 as before in my enviroment .

But I had issue

Traceback (most recent call last): File "/cvmfs/cms.cern.ch/el9_amd64_gcc13/cms/cmssw/CMSSW_16_0_0_pre2/bin/el9_amd64_gcc13/runTheMatrix.py", line 1037, in <module> ret = runSelected(opt) File "/cvmfs/cms.cern.ch/el9_amd64_gcc13/cms/cmssw/CMSSW_16_0_0_pre2/bin/el9_amd64_gcc13/runTheMatrix.py", line 32, in runSelected if len(undefSet)>0: raise ValueError('Undefined workflows: '+', '.join(map(str,list(undefSet)))) ValueError: Undefined workflows: 34434.758 ,

I want to ask is it still validate command to test.

mmusich · 2026-03-12T12:16:05Z

@cmsbuild, please test

mmusich · 2026-03-12T13:44:12Z

@Chihwan-An
in my test the relval that fails is still

34434.758_TTbar_14TeV+Run4D121_HLT75e33TimingTiclBarrel Step0-PASSED Step1-FAILED Step2-NOTRUN  - time date Thu Mar 12 13:31:58 2026-date Thu Mar 12 13:27:18 2026; exit: 0 35584 0

cmsbuild · 2026-03-12T13:58:52Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/51916/summary.html
COMMIT: d4b20cb
CMSSW: CMSSW_16_1_X_2026-03-11-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/51916/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Failed RelVals

34434.758

----- Begin Fatal Exception 12-Mar-2026 14:13:31 CET-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
Dependent module later on Path
  module 'hltParticleFlowRecHitECALUnseeded' depends on 'hltEcalDetIdToBeRecovered' which is later on path HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1
----- End Fatal Exception -------------------------------------------------

cmsbuild · 2026-03-13T07:26:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/48496

There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_75e33_cff.py modified in PR(s): TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932, TRK CPU vs. GPU path and infrastructure for Phase 2 HLT #50336
- File HLTrigger/Configuration/python/HLT_75e33_timing_cff.py modified in PR(s): TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932

cmsbuild · 2026-03-13T07:26:55Z

Pull request #49637 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

mmusich · 2026-03-13T07:46:27Z

@cmsbuild, please test

mmusich · 2026-03-13T07:47:53Z

+    inputTag = cms.InputTag("hltHpsSelectedPFTauLooseTauWPDeepTau"),
+    saveTags = cms.bool(True),
+    triggerType = cms.int32(84)
+)


picky but newline is missing.

mmusich · 2026-03-13T07:48:42Z

+    + hltHpsSelectedPFTauLooseTauWPDeepTau 
+    + hltHpsPFTau150LooseTauWPDeepTau 
+    + HLTEndSequence 
+)


picky but newline is missing.

cmsbuild · 2026-03-13T08:08:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/48497

There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_75e33_cff.py modified in PR(s): TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932, TRK CPU vs. GPU path and infrastructure for Phase 2 HLT #50336
- File HLTrigger/Configuration/python/HLT_75e33_timing_cff.py modified in PR(s): TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932

cmsbuild · 2026-03-13T08:09:06Z

Pull request #49637 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

mmusich · 2026-03-13T08:10:06Z

please test

cmsbuild · 2026-03-13T10:14:51Z

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/51936/summary.html
COMMIT: 198c6ab
CMSSW: CMSSW_16_1_X_2026-03-12-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/51936/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 25 differences found in the comparisons
DQMHistoTests: Total files compared: 66
DQMHistoTests: Total histograms compared: 4566828
DQMHistoTests: Total failures: 278
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4566530
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 65 files compared)
Checked 274 log files, 234 edm output root files, 66 DQM output files
TriggerResults: found differences in 1 / 64 workflows

mmusich · 2026-03-13T22:34:45Z

Updated timing cost of the additions:

Phase2 timing menu (on GPU)

`CMSSW_16_1_X_2026-03-12-2300`	`CMSSW_16_1_X_2026-03-12-2300` + this PR

concentrated in the Tau, HGcal and Tracking categories:

From 6245.8 ms/ev to 6378.1 ms/ev , thus a +2.11% increase.

cmsbuild · 2026-04-04T12:40:52Z

Milestone for this pull request has been moved to CMSSW_17_0_X. Please open a backport if it should also go in to CMSSW_16_1_X.

cmsbuild added this to the CMSSW_16_0_X milestone Dec 16, 2025

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Dec 16, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 16, 2025

cmsbuild added tests-started and removed tests-pending labels Dec 16, 2025

cmsbuild added tests-approved and removed tests-started labels Dec 16, 2025

cmsbuild added tests-started and removed tests-approved labels Dec 16, 2025

cmsbuild added the hold label Dec 16, 2025

cmsbuild added tests-rejected and removed tests-started labels Dec 17, 2025

cmsbuild mentioned this pull request Mar 3, 2026

Spring Cleaning of unused global PSets in Phase-2 HLT menus #50293

Merged

cmsbuild mentioned this pull request Mar 6, 2026

TRK CPU vs. GPU path and infrastructure for Phase 2 HLT #50336

Merged

cmsbuild added tests-started and removed tests-rejected labels Mar 12, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 12, 2026

runmatrix error fixed

850cd4b

Chihwan-An force-pushed the SingleTau_Trigger_v1 branch from d4b20cb to 850cd4b Compare March 13, 2026 07:24

cmsbuild removed the tests-rejected label Mar 13, 2026

mmusich reviewed Mar 13, 2026

View reviewed changes

new empty line added

198c6ab

cmsbuild mentioned this pull request Apr 7, 2026

LST: add LSTGeometry package and associated ESProducer #50679

Open

Conversation

Chihwan-An commented Dec 16, 2025

Uh oh!

cmsbuild commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Dec 16, 2025

Uh oh!

cmsbuild commented Dec 16, 2025

Uh oh!

Martin-Grunewald commented Dec 16, 2025

Uh oh!

cmsbuild commented Dec 16, 2025

Comparison Summary

Uh oh!

mmusich commented Dec 16, 2025

Uh oh!

mmusich commented Dec 16, 2025

Uh oh!

mmusich commented Dec 16, 2025

Uh oh!

mmusich commented Dec 16, 2025

Uh oh!

cmsbuild commented Dec 16, 2025

Uh oh!

mmusich commented Dec 17, 2025

Uh oh!

smuzaffar commented Dec 17, 2025

Uh oh!

cmsbuild commented Dec 17, 2025

Failed RelVals

Uh oh!

mmusich commented Feb 17, 2026

Uh oh!

Chihwan-An commented Feb 19, 2026

Uh oh!

mmusich commented Mar 6, 2026

Uh oh!

Chihwan-An commented Mar 11, 2026

Uh oh!

mmusich commented Mar 11, 2026

Uh oh!

Chihwan-An commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusich commented Mar 12, 2026

Uh oh!

mmusich commented Mar 12, 2026

Uh oh!

cmsbuild commented Mar 12, 2026

Failed RelVals

Uh oh!

cmsbuild commented Mar 13, 2026

Uh oh!

cmsbuild commented Mar 13, 2026

Uh oh!

mmusich commented Mar 13, 2026

Uh oh!

mmusich Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

mmusich Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Mar 13, 2026

Uh oh!

cmsbuild commented Mar 13, 2026

Uh oh!

mmusich commented Mar 13, 2026

Uh oh!

cmsbuild commented Mar 13, 2026

Comparison Summary

Uh oh!

mmusich commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Phase2 timing menu (on GPU)

Uh oh!

cmsbuild commented Apr 4, 2026

Uh oh!

Reviewers

cmsbuild commented Dec 16, 2025 •

edited

Loading

Chihwan-An commented Mar 12, 2026 •

edited

Loading

mmusich commented Mar 13, 2026 •

edited

Loading