Use string_view to fix constexpr std::string comp error in UBSAN_X IBs

[akritkbehera]

PR description:

• Converted static constexpr arrays (layerTypes_, waferType_, waferTypeX_) to use std::string_view

Refer: #49763 (comment)

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49792/47425

[akritkbehera]

please test for CMSSW_16_1_UBSAN_X

[cmsbuild]

A new Pull Request was created by @akritkbehera for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry)

@Dr15Jones, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @martinamalberti this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e4dd7/50563/summary.html
COMMIT: 61fcd73
CMSSW: CMSSW_16_1_UBSAN_X_2026-01-12-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49792/50563/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @missirol L1-uGT emulator: fix to AXOL1TL's "Pt" inputs #49753

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e4dd7/50563/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e4dd7/50563/git-merge-result

Failed Build

I found compilation error when building:

>> Compiling edm plugin src/Geometry/CaloTopology/test/HcalTopologyTester.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DCMS_UNDEFINED_SANITIZER -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DGNU_GCC -DG4V9 -DGNU_GCC -DG4V9 -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_16_1_UBSAN_X_2026-01-12-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_1_UBSAN_X_2026-01-12-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/cms/cmssw/CMSSW_16_1_UBSAN_X_2026-01-12-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/dd4hep/v01-31-0x-8ab5d7f72a3cba6ad98d36bb3079f158/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/geant4/11.2.2-094dbb1158516ecfa47b0e5435e73c6a/include/Geant4 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/geant4/11.2.2-094dbb1158516ecfa47b0e5435e73c6a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/boost/1.80.0-b819d3899535842b3b08dcd6a725af1a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/clhep/2.4.7.1-caf57578c24c3884afdedd94a88b58d7/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/expat/2.4.8-90d4121d63d495f95df72519ccbb6e9c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/gsl/2.6-9011a41928244b609ca4c22c439b3fef/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/lcg/root/6.36.07-bd71f88d9cd20e5042c0ac03a7e23595/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/tbb/v2022.3.0-88eb7be4ee320d604a798a914aea6359/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/vecgeom/v1.2.11-a447d0f7bbf17b0a834452d93097bc3c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/vecgeom/v1.2.11-a447d0f7bbf17b0a834452d93097bc3c/include/VecGeom -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/xerces-c/3.1.3-ab719034dc2061fa61b09353203a0c2d/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-95c02b8a883b2934decb8bb53ff9b486/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-95c02b8a883b2934decb8bb53ff9b486/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/OpenBLAS/0.3.27-da4a3c2bb8ae43f3913a4a44acdb1b50/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-omit-frame-pointer -fsanitize=undefined -fsanitize=builtin -fsanitize=pointer-overflow -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -ftls-model=global-dynamic -pthread -DBOOST_DISABLE_ASSERTS -g -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/HcalTopologyTester.cc.d src/Geometry/CaloTopology/test/HcalTopologyTester.cc -o tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/HcalTopologyTester.cc.o
>> Building edm plugin tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/libtestGeometryCaloTopology.so
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-omit-frame-pointer -fsanitize=undefined -fsanitize=builtin -fsanitize=pointer-overflow -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -ftls-model=global-dynamic -pthread -DBOOST_DISABLE_ASSERTS -g -shared -Wl,-E    -Wl,-z,defs     tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/CaloTowerMapTester.cc.o tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/CaloTowerTopologyTester.cc.o tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/HGCalTBTopologyTester.cc.o tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/HGCalTopologyTester.cc.o tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/HcalDetId2DenseTester.cc.o tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/HcalTopologyTester.cc.o -o tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/libtestGeometryCaloTopology.so -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_1_UBSAN_X_2026-01-12-2300/biglib/el8_amd64_gcc13 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_1_UBSAN_X_2026-01-12-2300/lib/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/cms/cmssw/CMSSW_16_1_UBSAN_X_2026-01-12-2300/biglib/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/cms/cmssw/CMSSW_16_1_UBSAN_X_2026-01-12-2300/lib/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/cms/cmssw/CMSSW_16_1_UBSAN_X_2026-01-12-2300/external/el8_amd64_gcc13/lib -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_1_UBSAN_X_2026-01-12-2300/static/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/cms/cmssw/CMSSW_16_1_UBSAN_X_2026-01-12-2300/static/el8_amd64_gcc13 -lGeometryHcalTowerAlgo -lGeometryCaloTopology -lGeometryHcalCommonData -lDetectorDescriptionRegressionTest -lGeometryCaloGeometry -lGeometryHGCalTBCommonData -lDataFormatsCaloTowers -lDetectorDescriptionParser -lGeometryHGCalCommonData -lGeometryRecords -lCondFormatsAlignmentRecord -lDataFormatsCandidate -lDetectorDescriptionCore -lDetectorDescriptionDDCMS -lCondFormatsGeometryObjects -lDataFormatsEcalDetId -lDataFormatsForwardDetId -lDataFormatsGeometryVector -lDataFormatsHcalDetId -lFWCoreFramework -lSimDataFormatsCaloHit -lDataFormatsDetId -lDataFormatsMath -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreAbstractServices -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCoreConcurrency -lFWCorePluginManager -lFWCoreReflection -lCondFormatsSerialization -lFWCoreUtilities -lFWCoreVersion -lSimDataFormatsEncodedEventId -lUtilitiesXerces -lDDAlign -lDDCond -lDDCore -lDDParsers -lPhysics -lHist -lMatrix -lGenVector -lMathMore -lTree -lNet -lGeom -lThread -lG4digits_hits -lG4error_propagation -lG4event -lG4geometry -lG4global -lG4graphics_reps -lG4intercoms -lG4interfaces -lG4materials -lG4parmodels -lG4particles -lG4geomtext -lG4mctruth -lG4gdml -lG4physicslists -lG4processes -lG4readout -lG4run -lG4tracking -lG4track -lG4analysis -lG4ptl -lMathCore -lRIO -lboost_program_options -lboost_serialization -lCore -lboost_thread -lboost_date_time -lCLHEP -lpcre -lvecgeom -lbz2 -lexpat -lgsl -luuid -ltbb -lxerces-c -llzma -lz -lcms-md5 -lopenblas -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.4.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lGeometryHcalTowerAlgo: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc13/src/Geometry/CaloTopology/test/testGeometryCaloTopology/libtestGeometryCaloTopology.so] Error 1
Leaving library rule at src/Geometry/CaloTopology/test
>> Leaving Package Geometry/CaloTopology
>> Package Geometry/CaloTopology built
>> Entering Package Geometry/CaloEventSetup


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49792/47435

[cmsbuild]

Pull request #49792 was updated. @Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @smuzaffar can you please check and sign again.

[akritkbehera]

please test for CMSSW_16_1_UBSAN_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49792/47849

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Geometry/HGCalCommonData/interface/HGCalTypes.h modified in PR(s): Revert "Phase2-hgx364X Add the tools with some more diagnostic help to debug the issue of wrong DetID->Position->DetID assignment" #49831
  • File Geometry/HGCalCommonData/src/HGCalTypes.cc modified in PR(s): Revert "Phase2-hgx364X Add the tools with some more diagnostic help to debug the issue of wrong DetID->Position->DetID assignment" #49831

[cmsbuild]

Pull request #49792 was updated. @Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please check and sign again.

[akritkbehera]

please test for CMSSW_16_1_UBSAN_X

[akritkbehera]

@akritkbehera can you rebase?

I guess this PR is not required anymore.
The issue was addressed here #49811

[akritkbehera]

@cmsbuild please hold

[cmsbuild]

Pull request has been put on hold by @akritkbehera
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e4dd7/51079/summary.html
COMMIT: 1576a6d
CMSSW: CMSSW_16_1_UBSAN_X_2026-02-02-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49792/51079/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-ngt-hlt [NGT] add hltESPMkFit to NGTScouting menu #50008
• @makortel Use signed integer for "present actual" and "max actual" in AllocMonitors #50002
• @Dr15Jones Added Fwd.h files to DataFormats/PatCandidates #49998

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e4dd7/51079/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e4dd7/51079/git-merge-result

[kpedro88]

apologies @akritkbehera , I was looking at pre1 instead of master.

(personally I like the string_view solution better. but since the originating PR is under question for other reasons, let's leave this on hold for now and I'll get back to you soon.)

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_17_0_X. Please open a backport if it should also go in to CMSSW_16_1_X.