Phase2-hgx365K The ordering of wafer types corrected and also ID from position is corrected for HGCal#50043
Conversation
…rrected for HGCal
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50043/47895
|
|
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
+1 Size: This PR adds an extra 44KB to repository Comparison SummarySummary:
|
|
please test workflows 34551.85,34634.114,34634.21,34634.703,34634.99,34634.9921,34634.999 lets see if it fixes the failing workflows in IB |
|
Hi - I just tried from a L1T use case: i.e. running in 16_1_0_pre1 + this PR over Spring24 MC but (unless I did something wrong) it does not seem to fix things? I used the following recipe: cmsrel CMSSW_16_1_0_pre1
cd CMSSW_16_1_0_pre1/src
cmsenv
voms-proxy-init -voms cms
git cms-init
git cms-addpkg Geometry/HGCalCommonData
git fetch official-cmssw pull/50043/head:HGCalFix
git checkout HGCalFix
scram b -j 16
cmsDriver.py -s L1TrackTrigger,L1,L1P2GT,NANO:@Phase2L1DPGwithGen \
--conditions auto:phase2_realistic_T33 \
--geometry ExtendedRun4D110 \
--era Phase2C17I13M9 \
--eventcontent NANOAODSIM \
--datatier GEN-RECO-L1NANO \
--customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000,Configuration/DataProcessing/Utils.addMonitoring,L1Trigger/Configuration/customisePhase2TTOn110.customisePhase2TTOn110 \
--filein /store/mc/Phase2Spring24DIGIRECOMiniAOD/QCD_Pt-20To30_TuneCP5_14TeV-pythia8/GEN-SIM-DIGI-RAW-MINIAOD/PU200_Trk1GeV_140X_mcRun4_realistic_v4-v1/120000/000e6684-7f91-49e0-befb-0a7793ce1ce4.root \
--fileout file:QCD_Phase2_L1T.root \
--python_filename rerunL1wNano_cfg.py \
--inputCommands="keep *, drop l1tPFJets_*_*_*, drop l1tTrackerMuons_l1tTkMuonsGmt*_*_HLT" \
--mc -n 10 --nThreads 4And got the following error (again): An exception of category 'OutOfBound' occurred while
[0] Processing Event run: 1 lumi: 358 event: 357004 stream: 0
[1] Running path 'Phase2L1GTProducer'
[2] Prefetching for module L1GTProducer/'l1tGTProducer'
[3] Prefetching for module L1SeedConePFJetProducer/'l1tSC4PFL1PuppiCorrectedEmulator'
[4] Prefetching for module DeregionizerProducer/'l1tLayer2Deregionizer'
[5] Prefetching for module L1TPFCandMultiMerger/'l1tLayer1'
[6] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
[7] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 0.0682754 out of the seeding histogram bounds 0.076 - 0.58 |
|
-1 Failed Tests: RelVals Failed RelVals |
|
Thi is not a fix for the failures. The PU files have to be rebuilt after merging this PR |
|
+geometry |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
@cmsbuild Please test |
|
@bsunanda there is a requirement from TSG that the Spring24 Phase 2 MC samples continue to be useable in the latest release for L1 development. If we cannot satisfy that in the geometry code, then we need to modify the |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
+1 |
6 participants
PR description:
The ordering of wafer types is corrected, and also ID from position is corrected for HGCal
PR validation:
Tested with overlap check and fireworks
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special