Enable DerivePointerAlignment in clang-format#50060
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50060/47921 |
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test though there is nothing to test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50060/47923 |
|
@cms-sw/orp-l2 , it would be nice to get this merged before the 23h00 IB. |
|
@makortel , any objections? we should get the in before 23h00 IB which will have new LLVM 21 |
|
+core Sounds good to me |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Size: This PR adds an extra 16KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
@cms-sw/orp-l2 , can we get this merged for 23h00 IB ? |
|
@cms-sw/orp-l2 , I am merging this otherwise next IB with LLVM21 will propose unnecessary code format changes |
To avoid a massive code formatting with LLVM21, as proposes in https://github.com/cms-sw/cmssw/pull/49293/changes#diff-1026e0038b722990204a42bed8a6f7c0ec2302aa79e3fad1959d62ba968edfa2R18, this PR suggested to enable DerivePointerAlignment code-format option. This should allow us a minimal code formatting change with new LLVM 21.
Without this change clang format form LLVM21 will try to format nearly all files. This should go in 23h00 IB so that new LLVM21 only suggest minimal changes (only order of 100 files should be re-formatted with new LLVVM21 and this change)