Enable RPD reconstruction for 2025 and 2026 heavy-ion data by hjbossi · Pull Request #50063 · cms-sw/cmssw

hjbossi · 2026-02-06T19:23:50Z

PR description:

This PR enables RPD reconstruction by default. Now safe due to incorporation and validation of the RPD geometry into the GT (see here: https://its.cern.ch/jira/browse/CMSALCA-348).

PR validation:

RPD reconstruction is run at foresting step for HIN, not included in central streams.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not necessary for past data-taking. Useful to have for the future - no backport needed.

Tagging HIN Colleagues: @mandrenguyen
Tagging HCAL colleagues: @abdoulline @akhukhun

cmsbuild · 2026-02-06T19:24:14Z

cms-bot internal usage

cmsbuild · 2026-02-06T19:25:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50063/47928

cmsbuild · 2026-02-06T19:26:06Z

A new Pull Request was created by @hjbossi for master.

It involves the following packages:

RecoLocalCalo/HcalRecProducers (reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@abdoulline, @apsallid, @bsunanda, @denizsun, @mariadalfonso, @salimcerci this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Moanwar · 2026-02-06T19:44:39Z

@cmsbuild please test

cmsbuild · 2026-02-06T20:54:03Z

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ad19/51163/summary.html
COMMIT: ff84100
CMSSW: CMSSW_16_1_X_2026-02-06-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50063/51163/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@bsunanda Phase2-hgx365K The ordering of wafer types corrected and also ID from position is corrected for HGCal #50043

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ad19/51163/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ad19/51163/git-merge-result

Failed RelVals

139.001

----- Begin Fatal Exception 06-Feb-2026 21:11:45 CET-----------------------
An exception of category 'Conditions not found' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_5_step'
   [2] Prefetching for module LogMessageMonitor/'TrackFinderLogMessageMonMB'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Calling method for module ZdcHitReconstructor_Run3/'zdcrecoRun3'
Exception Message:
Unavailable Conditions of type HcalChannelQuality for cell (0x54000080) (Det 5:5 subdet 2:2 ZDC- RPD 1,2)
----- End Fatal Exception -------------------------------------------------

Failed RelVals-INPUT

138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log
138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
143.921143.921_RunOXY2025/step2_RunOXY2025.log

Expand to see more relval errors ...

abdoulline · 2026-02-07T05:26:33Z

Well, it can be safely active only starting from fall 2025 HI data onwards 🤔
In general - it's worth testing any branch with runTheMatrix before submitting a PR.

cmsbuild · 2026-02-08T01:05:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50063/47940

cmsbuild · 2026-02-08T01:06:03Z

Pull request #50063 was updated. @Moanwar, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

abdoulline · 2026-04-16T11:13:04Z

Looks like for summer 2025 HI 143.912_RunOXY2025 we don't have RPD conditions... 🤔

hjbossi · 2026-04-16T13:35:01Z

This is unexpected behavior, but it is related to what @abdoulline suggests above. We will need to check where the conditions are set for the run the matrix workflows, this I am not familiar with. These are IOV based conditions, so we need to check that the run number picked up actually included RPD conditions...

abdoulline · 2026-04-16T13:56:58Z

This is unexpected behavior, but it is related to what @abdoulline suggests above. We will need to check where the conditions are set for the run the matrix workflows, this I am not familiar with. These are IOV based conditions, so we need to check that the run number picked up actually included RPD conditions...

I'm afraid we cannot go back in time and modify Prompt conditions used in summer 2025 data taking.
For rereco Offline conditions there is much more flexibility.

stahlleiton · 2026-04-16T15:44:35Z

This is unexpected behavior, but it is related to what @abdoulline suggests above. We will need to check where the conditions are set for the run the matrix workflows, this I am not familiar with. These are IOV based conditions, so we need to check that the run number picked up actually included RPD conditions...

The issue could be fixed by changing in Configuration/Eras/python/Era_Run3_2025_UPC_OXY_cff.py :

from Configuration.ProcessModifiers.rpdReco_cff import rpdReco

Run3_2025_UPC_OXY = cms.ModifierChain(Run3_2025_UPC.copyAndExclude([rpdReco]), run3_oxygen)

hjbossi · 2026-04-16T17:37:01Z

Thanks @stahlleiton, I have implemented your suggested workaround. Let's see if this fixes it.

cmsbuild · 2026-04-16T17:38:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50063/49030

cmsbuild · 2026-04-16T17:39:06Z

Pull request #50063 was updated. @Moanwar, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

mandrenguyen · 2026-04-17T05:13:17Z

please test

cmsbuild · 2026-04-17T07:26:23Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ad19/52709/summary.html
COMMIT: 8a3aa02
CMSSW: CMSSW_17_0_X_2026-04-16-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50063/52709/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186437
DQMHistoTests: Total failures: 47
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186370
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

jfernan2 · 2026-04-17T09:28:34Z

please test
I'd like to repeat the test since exactly the relval which we want to check failed at DAS step

cmsbuild · 2026-04-17T13:21:20Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ad19/52716/summary.html
COMMIT: 8a3aa02
CMSSW: CMSSW_17_0_X_2026-04-17-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50063/52716/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186437
DQMHistoTests: Total failures: 44
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186373
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

abdoulline · 2026-04-17T13:24:46Z

Seems to be OK now.
Step2 log of wf of interest:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ad19/52716/runTheMatrixINPUT-results/143.912_RunOXY2025/step2_RunOXY2025.log

hjbossi · 2026-04-17T13:27:33Z

Yes, I agree, tests look good - probably safe to merge these fixes.

jfernan2 · 2026-04-17T15:48:09Z

+1

cmsbuild · 2026-04-17T15:48:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-04-18T04:51:53Z

+1

cmsbuild added this to the CMSSW_16_1_X milestone Feb 6, 2026

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 6, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 6, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 6, 2026

cmsbuild added tests-rejected and removed tests-started labels Feb 6, 2026

cmsbuild added operations-pending tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Feb 8, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 8, 2026

hjbossi marked this pull request as draft February 8, 2026 22:02

hjbossi marked this pull request as ready for review February 9, 2026 18:44

mandrenguyen changed the title ~~Enable RPD reconstruction by default.~~ Enable RPD reconstruction for 2025 and 2026 heavy-ion data Feb 9, 2026

Workaround for missing conditions in summer 2025.

8a3aa02

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Apr 16, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 16, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 17, 2026

cmsbuild added tests-rejected and removed tests-started labels Apr 17, 2026

cmsbuild removed the tests-rejected label Apr 17, 2026

This was referenced Apr 18, 2026

Add CXXFLAGS for unused result warning cms-sw/cmsdist#10492

Merged

[EVO] Fix merge conflicts 2026/04/20 #50767

Merged

Conversation

hjbossi commented Feb 6, 2026

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 6, 2026

Uh oh!

cmsbuild commented Feb 6, 2026

Uh oh!

Moanwar commented Feb 6, 2026

Uh oh!

cmsbuild commented Feb 6, 2026

Failed RelVals

Failed RelVals-INPUT

Uh oh!

abdoulline commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 8, 2026

Uh oh!

cmsbuild commented Feb 8, 2026

Uh oh!

abdoulline commented Apr 16, 2026

Uh oh!

hjbossi commented Apr 16, 2026

Uh oh!

abdoulline commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stahlleiton commented Apr 16, 2026

Uh oh!

hjbossi commented Apr 16, 2026

Uh oh!

cmsbuild commented Apr 16, 2026

Uh oh!

cmsbuild commented Apr 16, 2026

Uh oh!

mandrenguyen commented Apr 17, 2026

Uh oh!

cmsbuild commented Apr 17, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

jfernan2 commented Apr 17, 2026

Uh oh!

cmsbuild commented Apr 17, 2026

Comparison Summary

Uh oh!

abdoulline commented Apr 17, 2026

Uh oh!

hjbossi commented Apr 17, 2026

Uh oh!

jfernan2 commented Apr 17, 2026

Uh oh!

cmsbuild commented Apr 17, 2026

Uh oh!

mandrenguyen commented Apr 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cmsbuild commented Feb 6, 2026 •

edited

Loading

abdoulline commented Feb 7, 2026 •

edited

Loading

abdoulline commented Apr 16, 2026 •

edited

Loading