Implement heterogeneous Association Map based on SoA blocks by sbaldu · Pull Request #49995 · cms-sw/cmssw

sbaldu · 2026-02-01T14:30:48Z

PR description:

This PR implements an association map based on SoA blocks. In order to provide the accessors to the map's properties and content, the PR also enables the definition of SoA view methods.

PR validation:

The PR includes a test of the construction and fill of the map and checks the correctness of the content and the accessor methods.

FYI @felicepantaleo

cmsbuild · 2026-02-01T14:31:13Z

cms-bot internal usage

cmsbuild · 2026-02-01T14:33:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49995/47797

cmsbuild · 2026-02-01T14:33:27Z

A new Pull Request was created by @sbaldu for master.

It involves the following packages:

DataFormats/AssociationMap (****)
DataFormats/SoATemplate (heterogeneous)

The following packages do not have a category, yet:

DataFormats/AssociationMap
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

fwyzard · 2026-02-02T08:53:35Z

type ngt

makortel · 2026-02-02T14:25:03Z

+#include <cstdint>
+#include <type_traits>
+
+namespace ticl {


Is this utility specific to TICL or intended for more general usage?

As of now the main usage is TICL

Would it be feasible to include this code in a package that already uses TICL?

Or, the motivation to place this code in its own package is not clear.

Thanks for the suggestion. I've now put the map under a new DataFormats/TICL package

With @felicepantaleo we decided to add a new package for TICL data formats and we'll start moving the structures specific for TICL there

With @felicepantaleo we decided to add a new package for TICL data formats and we'll start moving the structures specific for TICL there

Ok. I guess at least @cms-sw/reconstruction-l2 should sign it? What about @cms-sw/heterogeneous-l2?

What about @cms-sw/heterogeneous-l2?

This too, I guess 🤷🏻‍♂️

cmsbuild · 2026-02-02T15:59:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49995/47813

cmsbuild · 2026-02-02T16:00:18Z

Pull request #49995 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

cmsbuild · 2026-02-03T11:23:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49995/47834

cmsbuild · 2026-02-03T11:23:56Z

Pull request #49995 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

fwyzard · 2026-03-26T18:08:49Z

@sbaldu any updates on the open points ?

sbaldu · 2026-03-29T22:37:45Z

@sbaldu any updates on the open points ?

With Felice we are discussing on how to solve the issue regarding the number of keys passed in the interface

fix template ordering

cmsbuild · 2026-04-01T08:22:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49995/48806

Found files with invalid states:
- DataFormats/AssociationMap/test/alpaka/TestAssociationMap.dev.cc:
  - Added: 51cfa2b
  - Modified: 8ef1767, ba90180
  - Deleted: 0655cf2
- DataFormats/AssociationMap/interface/FillAssociator.h:
  - Added: 51cfa2b
  - Modified: c5e0b85, 8ef1767, ba90180
  - Deleted: 0655cf2
- DataFormats/AssociationMap/interface/detail/FillAssociator.h:
  - Added: 51cfa2b
  - Modified: c5e0b85, 8ef1767, ba90180
  - Deleted: 0655cf2
- DataFormats/AssociationMap/test/BuildFile.xml:
  - Added: 51cfa2b
  - Deleted: 0655cf2
- DataFormats/AssociationMap/BuildFile.xml:
  - Added: 51cfa2b
  - Modified: 027d712
  - Deleted: 0655cf2
- DataFormats/AssociationMap/interface/AssociationMap.h:
  - Added: 51cfa2b
  - Modified: c5e0b85
  - Deleted: 0655cf2
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/SoATemplate/README.md modified in PR(s): Added AoSWrapper and transposition function #49072, Document constexpr limitation for SoA custom methods #49203, [Draft] Allow users to set a valid data range for the SoA View #49204
- File DataFormats/SoATemplate/interface/SoABlocks.h modified in PR(s): [DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565
- File DataFormats/SoATemplate/test/SoACustomizedMethods_t.cc modified in PR(s): Document constexpr limitation for SoA custom methods #49203
- File DataFormats/TICL/BuildFile.xml modified in PR(s): [DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565
- File DataFormats/TICL/interface/AssociationMap.h modified in PR(s): [DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565
- File DataFormats/TICL/interface/FillAssociator.h modified in PR(s): [DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565
- File DataFormats/TICL/interface/detail/FillAssociator.h modified in PR(s): [DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565

cmsbuild · 2026-04-01T08:23:07Z

Pull request #49995 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

cmsbuild · 2026-04-04T12:41:14Z

Milestone for this pull request has been moved to CMSSW_17_0_X. Please open a backport if it should also go in to CMSSW_16_1_X.

cmsbuild added this to the CMSSW_16_1_X milestone Feb 1, 2026

cmsbuild added pending-signatures tests-pending orp-pending new-package-pending code-checks-pending heterogeneous-pending labels Feb 1, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 1, 2026

cmsbuild added the ngt label Feb 2, 2026

makortel reviewed Feb 2, 2026

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 2, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 2, 2026

fwyzard reviewed Feb 2, 2026

View reviewed changes

Comment thread DataFormats/AssociationMap/interface/FillAssociator.h Outdated

fwyzard reviewed Feb 2, 2026

View reviewed changes

Comment thread DataFormats/AssociationMap/interface/FillAssociator.h Outdated

sbaldu force-pushed the feature/heterogeneous-associator branch from a9ddafa to 9b406b0 Compare February 3, 2026 11:22

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 3, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 3, 2026

cmsbuild mentioned this pull request Mar 26, 2026

[DO NOT MERGE] Testing new CaloClusterSoA DataFormats #50565

Draft

sbaldu added 13 commits March 31, 2026 13:44

Add definition of view methods in SoABlocks

d217849

Implement heterogeneous Association Map

51cfa2b

Add missing package in build file

027d712

Use include guards

c5e0b85

Improve namespace use

8ef1767

Use alpaka accelerator concept

ba90180

Rename AssociationMap package as TICL

0655cf2

Remove comment from soa blocks

b957e40

Refactor offsets calculation and use

24269a1

Swap map's templates and address comments

7f5ff15

Add tests and documentation for View methods

5d361ab

fix template ordering

Fixes

f8db6ab

Add test with non-defaulted map

3afd345

sbaldu force-pushed the feature/heterogeneous-associator branch from bc96eee to 3afd345 Compare April 1, 2026 08:21

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 1, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 1, 2026

cmsbuild modified the milestones: CMSSW_16_1_X, CMSSW_17_0_X Apr 4, 2026

Conversation

sbaldu commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 1, 2026

Uh oh!

cmsbuild commented Feb 1, 2026

Uh oh!

fwyzard commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

makortel Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

sbaldu Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

makortel Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

sbaldu Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

sbaldu Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

makortel Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

fwyzard Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented Feb 2, 2026

Uh oh!

cmsbuild commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented Feb 3, 2026

Uh oh!

cmsbuild commented Feb 3, 2026

Uh oh!

fwyzard commented Mar 26, 2026

Uh oh!

sbaldu commented Mar 29, 2026

Uh oh!

cmsbuild commented Apr 1, 2026

Uh oh!

cmsbuild commented Apr 1, 2026

Uh oh!

cmsbuild commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sbaldu commented Feb 1, 2026 •

edited

Loading

cmsbuild commented Feb 1, 2026 •

edited

Loading