[DO NOT MERGE] Testing new CaloClusterSoA DataFormats by waredjeb · Pull Request #50565 · cms-sw/cmssw

waredjeb · 2026-03-26T18:02:15Z

This is just to check with the cms-bot tests if this structure could work
Currently I am getting a weird crash on L1FPGATrackProducer that I don't understand and it is not clear how it is linked to these changes

@sbaldu @Electricks94 FYI

Co-authored-by: Felice Pantaleo <felice.pantaleo@cern.ch> Co-authored-by: Wahid Redjeb <wahid.redjeb@cern.ch> Co-authored-by: Aurora Perego <aurora.perego@cern.ch> Co-authored-by: Leonardo Beltrame <leonardobeltrame00@gmail.com>

cmsbuild · 2026-03-27T03:43:49Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50565/48748

Found files with invalid states:
- RecoHGCal/TICL/plugins/alpaka/PatternRecognitionPluginFactory.h:
  - Added: 3b75988
  - Modified: 12e9c7e
  - Deleted: 4fc9e2f
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterByAlgo.dev.cc:
  - Added: dbf3a72
  - Deleted: 70bbaa5
- RecoHGCal/TICL/plugins/alpaka/PatternRecognitionByCLUEstering.h:
  - Added: 388f63c
  - Modified: 4032467, cfb906e, 12e9c7e
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/interface/alpaka/CaloClusterDeviceCollection.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- DataFormats/CaloRecHit/interface/CaloClusterHostCollection.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- DataFormats/CaloRecHit/src/alpaka/classes_cuda.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterBase.h:
  - Added: dbf3a72
  - Deleted: 70bbaa5
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterByAlgoAndSize.dev.cc:
  - Added: 0b9b01d
  - Modified: 0a731ca, 12e9c7e
  - Deleted: 4fc9e2f
- RecoHGCal/TICL/plugins/alpaka/PatternRecognitionPluginFactory.dev.cc:
  - Added: 3b75988
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/src/alpaka/classes_rocm_def.xml:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- RecoHGCal/TICL/plugins/alpaka/HeterogeneousTracksterProducer.cc:
  - Added: 388f63c
  - Modified: 4032467, 3b75988
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/interface/CaloClusterSoA.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- RecoHGCal/TICL/plugins/alpaka/PatternRecognitionByCLUEstering.dev.cc:
  - Added: 388f63c
  - Modified: 4032467, 3b75988, cfb906e, 49a6329, 0b9b01d
  - Deleted: 4fc9e2f
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterByAlgo.h:
  - Added: dbf3a72
  - Deleted: 70bbaa5
- RecoHGCal/TICL/plugins/alpaka/FilteredLayerClustersProducer.cc:
  - Added: 0b9b01d
  - Modified: 0a731ca, 12e9c7e
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/src/alpaka/classes_rocm.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterByAlgoAndSize.h:
  - Added: dbf3a72
  - Modified: 0b9b01d, 0a731ca, 12e9c7e
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/src/alpaka/classes_cuda_def.xml:
  - Added: dbf3a72
  - Deleted: 12e9c7e
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/SoATemplate/interface/SoABlocks.h modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File DataFormats/TICL/BuildFile.xml modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File DataFormats/TICL/interface/AssociationMap.h modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File DataFormats/TICL/interface/FillAssociator.h modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File DataFormats/TICL/interface/detail/FillAssociator.h modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File RecoHGCal/TICL/plugins/BuildFile.xml modified in PR(s): Add directories for TICL-EGM code development #48319, TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50565/48748/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50565/48748/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

cmsbuild · 2026-03-27T03:47:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50565/48749

Found files with invalid states:
- RecoHGCal/TICL/plugins/alpaka/PatternRecognitionPluginFactory.h:
  - Added: 3b75988
  - Modified: 12e9c7e
  - Deleted: 4fc9e2f
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterByAlgo.dev.cc:
  - Added: dbf3a72
  - Deleted: 70bbaa5
- RecoHGCal/TICL/plugins/alpaka/PatternRecognitionByCLUEstering.h:
  - Added: 388f63c
  - Modified: 4032467, cfb906e, 12e9c7e
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/interface/alpaka/CaloClusterDeviceCollection.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- DataFormats/CaloRecHit/interface/CaloClusterHostCollection.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- DataFormats/CaloRecHit/src/alpaka/classes_cuda.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterBase.h:
  - Added: dbf3a72
  - Deleted: 70bbaa5
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterByAlgoAndSize.dev.cc:
  - Added: 0b9b01d
  - Modified: 0a731ca, 12e9c7e
  - Deleted: 4fc9e2f
- RecoHGCal/TICL/plugins/alpaka/PatternRecognitionPluginFactory.dev.cc:
  - Added: 3b75988
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/src/alpaka/classes_rocm_def.xml:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- RecoHGCal/TICL/plugins/alpaka/HeterogeneousTracksterProducer.cc:
  - Added: 388f63c
  - Modified: 4032467, 3b75988
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/interface/CaloClusterSoA.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- RecoHGCal/TICL/plugins/alpaka/PatternRecognitionByCLUEstering.dev.cc:
  - Added: 388f63c
  - Modified: 4032467, 3b75988, cfb906e, 49a6329, 0b9b01d
  - Deleted: 4fc9e2f
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterByAlgo.h:
  - Added: dbf3a72
  - Deleted: 70bbaa5
- RecoHGCal/TICL/plugins/alpaka/FilteredLayerClustersProducer.cc:
  - Added: 0b9b01d
  - Modified: 0a731ca, 12e9c7e
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/src/alpaka/classes_rocm.h:
  - Added: dbf3a72
  - Deleted: 12e9c7e
- RecoHGCal/TICL/plugins/alpaka/ClusterFilterByAlgoAndSize.h:
  - Added: dbf3a72
  - Modified: 0b9b01d, 0a731ca, 12e9c7e
  - Deleted: 4fc9e2f
- DataFormats/CaloRecHit/src/alpaka/classes_cuda_def.xml:
  - Added: dbf3a72
  - Deleted: 12e9c7e
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/SoATemplate/interface/SoABlocks.h modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File DataFormats/TICL/BuildFile.xml modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File DataFormats/TICL/interface/AssociationMap.h modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File DataFormats/TICL/interface/FillAssociator.h modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File DataFormats/TICL/interface/detail/FillAssociator.h modified in PR(s): Implement heterogeneous Association Map based on SoA blocks #49995
- File RecoHGCal/TICL/plugins/BuildFile.xml modified in PR(s): Add directories for TICL-EGM code development #48319, TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932

cmsbuild · 2026-03-27T03:48:00Z

Pull request #50565 was updated.

waredjeb · 2026-03-27T03:48:17Z

please test

cmsbuild · 2026-03-27T09:09:27Z

-1

Failed Tests: HeaderConsistency UnitTests RelVals RelVals-AMD_MI300X
Size: This PR adds an extra 192KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ebb0/52303/summary.html
COMMIT: efebe87
CMSSW: CMSSW_16_1_X_2026-03-26-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50565/52303/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test testProduceNanoHLT had ERRORS

Failed RelVals

34434.911

----- Begin Fatal Exception 27-Mar-2026 06:03:38 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=HGCalLayerClusterProducer label='hltHgcalLayerClustersEE'
   [2] Calling ProductRegistryHelper::addToRegistry, checking dictionaries for produced types
Exception Message:
No data dictionary found for the following classes:

  PortableHostCollection<reco::CaloClusterSoALayout<128,false> >
  edm::Wrapper<PortableHostCollection<reco::CaloClusterSoALayout<128,false> > >

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type declared by a producer module with the function 'produces'.
Instead it might be the type of a data member, base class,
wrapped type, or other object needed by a produced type. Below
is some additional information which lists the types declared
to be produced by a producer module that are associated with
the types whose dictionaries were not found:

  PortableHostCollection<reco::CaloClusterSoALayout<128,false> >

----- End Fatal Exception -------------------------------------------------

34434.0

----- Begin Fatal Exception 27-Mar-2026 05:58:52 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=HGCalLayerClusterProducer label='hltHgcalLayerClustersEE'
   [2] Calling ProductRegistryHelper::addToRegistry, checking dictionaries for produced types
Exception Message:
No data dictionary found for the following classes:

  PortableHostCollection<reco::CaloClusterSoALayout<128,false> >
  edm::Wrapper<PortableHostCollection<reco::CaloClusterSoALayout<128,false> > >

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type declared by a producer module with the function 'produces'.
Instead it might be the type of a data member, base class,
wrapped type, or other object needed by a produced type. Below
is some additional information which lists the types declared
to be produced by a producer module that are associated with
the types whose dictionaries were not found:

  PortableHostCollection<reco::CaloClusterSoALayout<128,false> >

----- End Fatal Exception -------------------------------------------------

34434.75

----- Begin Fatal Exception 27-Mar-2026 05:59:07 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=HGCalLayerClusterProducer label='hltHgcalLayerClustersEE'
   [2] Calling ProductRegistryHelper::addToRegistry, checking dictionaries for produced types
Exception Message:
No data dictionary found for the following classes:

  PortableHostCollection<reco::CaloClusterSoALayout<128,false> >
  edm::Wrapper<PortableHostCollection<reco::CaloClusterSoALayout<128,false> > >

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type declared by a producer module with the function 'produces'.
Instead it might be the type of a data member, base class,
wrapped type, or other object needed by a produced type. Below
is some additional information which lists the types declared
to be produced by a producer module that are associated with
the types whose dictionaries were not found:

  PortableHostCollection<reco::CaloClusterSoALayout<128,false> >

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

Failed RelVals-AMD_MI300X

34634.71334634.713_TTbar_14TeV+Run4D121PU_lstOnGPUIters01TrackingOnlyAlpakaValidationLST/step2_TTbar_14TeV+Run4D121PU_lstOnGPUIters01TrackingOnlyAlpakaValidationLST.log
34634.71234634.712_TTbar_14TeV+Run4D121PU_lstOnGPUIters01TrackingOnly/step2_TTbar_14TeV+Run4D121PU_lstOnGPUIters01TrackingOnly.log
34634.750334634.7503_TTbar_14TeV+Run4D121PU_HLTHeterogeneousValid/step2_TTbar_14TeV+Run4D121PU_HLTHeterogeneousValid.log

Expand to see more relval errors ...

cmsbuild · 2026-04-04T12:41:56Z

Milestone for this pull request has been moved to CMSSW_17_0_X. Please open a backport if it should also go in to CMSSW_16_1_X.

sbaldu and others added 22 commits March 20, 2026 11:35

First draft of heterogeneous trackster producer

388f63c

Create plugin factory for alpaka pattern recognition plugins

4032467

Add alpaka pattern recognition plugin factory

3b75988

Use scalar values for CLUEstering parameters

cfb906e

Use weighted chebyshev metric for cluestering

49a6329

Add TICL heterogeneous producer to BuildFile

ead3c3d

[WIP] use CLUEstering for legacy layer clusters

7b03afe

Remove HGCalImagingAlgo

fbe7fbe

Define ClusterMask and HitsAndFractions for TICL

8750227

Define LayerClusterAndAssociations wrapper

c32b25d

Update legacy LC producer (missing timing)

70bbaa5

Use CaloClusterSoA for alpaka LC producer

a280ac2

Implement heterogeneous LC merging

7a4910a

[WIP] Add heterogeneous filtered layer cluster producer

0b9b01d

Finalize heterogeneous filtered LC producer

0a731ca

Save cluster sizes in legacy producer SoA

f7693ea

[TEMPORARY] add association map headers

3652f37

Add workaround for legacy LC production in barrel

b5e6937

Test classes def fix

c1e4879

[TEMPORARY] unlock view methods and fix in associator

9f87ddd

Compute LC timing in legacy producer

12e9c7e

cmsbuild added this to the CMSSW_16_1_X milestone Mar 26, 2026

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending new-package-pending code-checks-pending xpog-pending labels Mar 26, 2026

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Mar 27, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 27, 2026

code-checks

efebe87

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 27, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 27, 2026

cmsbuild added tests-started and removed tests-pending labels Mar 27, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 27, 2026

This was referenced Apr 1, 2026

TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932

Open

Implement heterogeneous Association Map based on SoA blocks #49995

Open

cmsbuild modified the milestones: CMSSW_16_1_X, CMSSW_17_0_X Apr 4, 2026

cmsbuild mentioned this pull request Apr 17, 2026

Phase2 HLT nano workflows: miscelleaneous fixes for TICL-related modules. #50748

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] Testing new CaloClusterSoA DataFormats#50565

[DO NOT MERGE] Testing new CaloClusterSoA DataFormats#50565
waredjeb wants to merge 24 commits intocms-sw:masterfrom
waredjeb:test_classes_def

waredjeb commented Mar 26, 2026 •

edited

Loading

Uh oh!

cmsbuild commented Mar 27, 2026

Uh oh!

cmsbuild commented Mar 27, 2026

Uh oh!

cmsbuild commented Mar 27, 2026

Uh oh!

waredjeb commented Mar 27, 2026

Uh oh!

cmsbuild commented Mar 27, 2026

Uh oh!

cmsbuild commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

waredjeb commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Mar 27, 2026

Uh oh!

cmsbuild commented Mar 27, 2026

Uh oh!

cmsbuild commented Mar 27, 2026

Uh oh!

waredjeb commented Mar 27, 2026

Uh oh!

cmsbuild commented Mar 27, 2026

Failed Unit Tests

Failed RelVals

Failed RelVals-AMD_MI300X

Uh oh!

cmsbuild commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

waredjeb commented Mar 26, 2026 •

edited

Loading