Updates L1T OMTF for Phase 2 by mbluj · Pull Request #50032 · cms-sw/cmssw

mbluj · 2026-02-04T13:57:27Z

PR description:

This PR introduces recent (as for beginning of 2026) changes in the L1T OMTF emulator for Phase2:

Algorithm adapted to the latest DT TPs;
Output candidates are returned as SAMuons (Phase 2 data format):
- Conversion to the Phase 2 scales is implemented;
- Some code refactoring was needed: an internal class FinalMuon was introduced that stores the candidate parameters in the output format. It can be either Phase 1 or Phase 2 scales. Then it is converted to RegionalMuonCands (Phase 1) or SAMuons (Phase 2);
Improvements and refactoring of CandidateSimMuonMatcher and DataROOTDumper2 used for developments and validations.

In addition the PR contains a fix of bugs found in DTTriggerPhase2 which are already included in #49589, but as it is not merged yet added here for self-consistency.

Details in this JIRA ticket and K. Bunkowski's presentation here.

This PR requires updated configuration files provided in cms-data/L1Trigger-L1TMuon#29.

PR validation:

Validated with Phase 2 workflows, e.g. 23634.0.

FYI, @akalinow, @kbunkow

cmsbuild · 2026-02-04T13:58:04Z

cms-bot internal usage

cmsbuild · 2026-02-04T14:00:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50032/47864

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc modified in PR(s): [L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3 #49589

cmsbuild · 2026-02-04T14:00:48Z

A new Pull Request was created by @mbluj for master.

It involves the following packages:

L1Trigger/DTTriggerPhase2 (l1)
L1Trigger/L1TMuonOverlapPhase1 (l1)
L1Trigger/L1TMuonOverlapPhase2 (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @battibass, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

quinnanm · 2026-02-04T21:47:52Z

please test

cmsbuild · 2026-02-04T21:54:55Z

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/51110/summary.html
COMMIT: 255348b
CMSSW: CMSSW_16_1_X_2026-02-04-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50032/51110/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

mbluj · 2026-02-05T14:20:47Z

Fixed issue found in tests with clang.

cmsbuild · 2026-02-05T14:22:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50032/47899

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc modified in PR(s): [L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3 #49589

cmsbuild · 2026-02-05T14:23:19Z

Pull request #50032 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

mbluj · 2026-02-05T14:23:20Z

Please test this PR with cms-data/L1Trigger-L1TMuon#29.

mbluj · 2026-02-09T12:04:34Z

I'd like to ask to start tests and eventually the review, thank you.

e.g. better use of const, cout=>MessageLogs, additional comments, etc.

mbluj · 2026-04-07T14:45:51Z

@quinnanm thank you for detailed review of this PR. The cd5692c should address you comments.

cmsbuild · 2026-04-07T14:55:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50032/48904

cmsbuild · 2026-04-07T14:55:28Z

Pull request #50032 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

quinnanm · 2026-04-13T21:55:52Z

please test

cmsbuild · 2026-04-14T00:52:34Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/52644/summary.html
COMMIT: cd5692c
CMSSW: CMSSW_17_0_X_2026-04-13-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50032/52644/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/52644/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/52644/git-merge-result

Comparison Summary

Summary:

You potentially added 18 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 54
DQMHistoTests: Total histograms compared: 4327611
DQMHistoTests: Total failures: 124
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4327467
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
Checked 232 log files, 201 edm output root files, 54 DQM output files
TriggerResults: no differences found

OMTFProcessor.cc and OmtfProcessorPhase2.cc Fixing the condition to assign minimum pT (0 or 1 GeV) for the muons that have only unconstrained pt valid. Checking getFiredLayerCntConstr was missing. updating runMuonOverlap_run3_mc.py and runMuonOverlap.py

cmsbuild · 2026-04-22T11:57:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50032/49097

cmsbuild · 2026-04-22T11:57:53Z

Pull request #50032 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

mbluj · 2026-04-22T12:02:38Z

A fix (by @kbunkow) has been added to the condition that assigns pt to an OMTF muon when only an "unconstrained" candidate is found. This should resolve the observed discrepancies between the updated and reference versions.

quinnanm · 2026-04-24T17:53:26Z

please test

cmsbuild · 2026-04-24T20:28:27Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/52869/summary.html
COMMIT: 70de929
CMSSW: CMSSW_17_0_X_2026-04-24-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50032/52869/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 54
DQMHistoTests: Total histograms compared: 4328160
DQMHistoTests: Total failures: 32
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4328108
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
Checked 232 log files, 201 edm output root files, 54 DQM output files
TriggerResults: no differences found

cmsbuild added this to the CMSSW_16_1_X milestone Feb 4, 2026

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 4, 2026

mbluj mentioned this pull request Feb 4, 2026

Updated configuration of OMTF for Phase2 cms-data/L1Trigger-L1TMuon#29

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 4, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 4, 2026

cmsbuild added tests-rejected tests-pending code-checks-pending and removed tests-started tests-rejected code-checks-approved labels Feb 4, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 5, 2026

cmsbuild mentioned this pull request Feb 10, 2026

[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3 #49589

Merged

Code cleaning and fixes,

cd5692c

e.g. better use of const, cout=>MessageLogs, additional comments, etc.

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 7, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 7, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 13, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 14, 2026

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Apr 22, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 22, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 24, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 24, 2026

Conversation

mbluj commented Feb 4, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 4, 2026

Uh oh!

cmsbuild commented Feb 4, 2026

Uh oh!

quinnanm commented Feb 4, 2026

Uh oh!

cmsbuild commented Feb 4, 2026

Failed Clang Build

Uh oh!

mbluj commented Feb 5, 2026

Uh oh!

cmsbuild commented Feb 5, 2026

Uh oh!

cmsbuild commented Feb 5, 2026

Uh oh!

mbluj commented Feb 5, 2026

Uh oh!

mbluj commented Feb 9, 2026

Uh oh!

mbluj commented Apr 7, 2026

Uh oh!

cmsbuild commented Apr 7, 2026

Uh oh!

cmsbuild commented Apr 7, 2026

Uh oh!

quinnanm commented Apr 13, 2026

Uh oh!

cmsbuild commented Apr 14, 2026

Comparison Summary

Uh oh!

cmsbuild commented Apr 22, 2026

Uh oh!

cmsbuild commented Apr 22, 2026

Uh oh!

mbluj commented Apr 22, 2026

Uh oh!

quinnanm commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Apr 24, 2026

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented Feb 4, 2026 •

edited

Loading

quinnanm commented Apr 24, 2026 •

edited

Loading