JME Offline DQM: adding trigger efficiency for scouting jets by etzovara · Pull Request #50188 · cms-sw/cmssw

etzovara · 2026-02-19T14:12:49Z

PR description:

This PR summarises changes in the cmssw/DQMOffline/Trigger/ framework in order to include trigger efficiency calculations for scouting jets for offline monitoring. The relevant modules run only with online and offline scouting DQM with scouting datasets, to avoid crash due to missing scouting objects (specifically rho) from other datasets. Also, modules w/o JECs have been created in order to avoid similar crash in RelVals. (Issues thoroughly described in #49377 and #49358).

Relevant reports about the development and validation of this work can be found in:

cc: @silviodonato @patinkaew

PR validation:

This PR has been prepared starting from:

cmsrel CMSSW_16_1_X_2026-02-15-2300
cd CMSSW_16_1_X_2026-02-15-2300/src
cmsenv
git cms-init
git cms-addpkg DQMOffline/HLTScouting DQMOffline/Trigger DQMOffline/Configuration DQMOffline/JetMET PhysicsTools/SelectorUtils DQM/HLTEvF
scram b
scram build code-checks
scram build code-format

[1]: input: ScoutingPFMonitor/AOD/PromptReco-v1/ dataset (specifically testing with files from era 2025G, run 398827)
[2]: cmsDriver.py step2 -s DQM:jetmetScoutingMonitorHLT--conditions 150X_dataRun3_Prompt_v1 --datatier DQMIO -n -1 --eventcontent DQM --geometry DB:Extended --era Run3 --filein /store/data/Run2025G/ScoutingPFMonitor/AOD/PromptReco-v1/000/398/827/00000/1b30ead2-bc1f-42c3-87ca-dba7b395d525.root --fileout file:stepDQM.root --python_filename DQM_cfg.py --data --scenario pp --no_exec (or cmsDriver.py step2 -s DQM:jetmetScoutingNoJECsMonitorHLT--conditions 150X_dataRun3_Prompt_v1 --datatier DQMIO -n -1 --eventcontent DQM --geometry DB:Extended --era Run3 --filein /store/data/Run2025G/ScoutingPFMonitor/AOD/PromptReco-v1/000/398/827/00000/1b30ead2-bc1f-42c3-87ca-dba7b395d525.root --fileout file:stepDQM.root --python_filename DQM_cfg.py --data --scenario pp --no_exec)
[3]: cmsRun DQM_cfg.py
[4]: cmsDriver.py step3 -s HARVESTING:hltOfflineDQMClient --harvesting AtRunEnd --filein file:stepDQM.root --python_filename harvesting_cfg.py --conditions 150X_dataRun3_Prompt_v1 --data --filetype DQM --scenario pp --era Run3 --geometry DB:Extended -n -1 --no_exec
[5]: cmsRun harvesting_cfg.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is intended for the master branch.
Since, it is for monitoring of 2025 and on data it should be backported to CMSSW_16_0_X (maybe also to CMSSW_15_0_X???).

…trigger efficiency

…xis for Scouting jets

…n (applying also JetID,JECs,MuonID muon isol)

cmsbuild · 2026-02-19T14:13:19Z

cms-bot internal usage

cmsbuild · 2026-02-19T14:15:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50188/48143

cmsbuild · 2026-02-19T14:16:06Z

A new Pull Request was created by @etzovara for master.

It involves the following packages:

DQMOffline/Trigger (dqm)
PhysicsTools/SelectorUtils (reconstruction)

@Moanwar, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mmusich, @mtosi, @rociovilar, @trocino this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

gabrielmscampos · 2026-02-19T14:27:32Z

please test

cmsbuild · 2026-02-19T16:49:59Z

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df860b/51437/summary.html
COMMIT: 77cb014
CMSSW: CMSSW_16_1_X_2026-02-19-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50188/51437/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

139.001

----- Begin Fatal Exception 19-Feb-2026 15:53:04 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_7_step'
   [2] Prefetching for module JetMonitor/'L1SingleJet200_Prommonitoring'
   [3] Prefetching for module ChainedJetCorrectorProducer/'ak4PFScoutL1FastL2L3ResidualCorrector'
   [4] Calling method for module L1FastjetCorrectorProducer/'ak4PFScoutL1FastjetCorrector'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: double
Looking for module label: hltScoutingPFPacker
Looking for productInstanceName: rho

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

1000.0

----- Begin Fatal Exception 19-Feb-2026 16:08:07 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 165121 lumi: 62 event: 23609118 stream: 0
   [1] Running path 'dqmoffline_11_step'
   [2] Prefetching for module JetMonitor/'L1SingleJet200_Prommonitoring'
   [3] Prefetching for module ChainedJetCorrectorProducer/'ak4PFScoutL1FastL2L3ResidualCorrector'
   [4] Calling method for module L1FastjetCorrectorProducer/'ak4PFScoutL1FastjetCorrector'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: double
Looking for module label: hltScoutingPFPacker
Looking for productInstanceName: rho

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

1001.0

----- Begin Fatal Exception 19-Feb-2026 16:08:43 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 165121 lumi: 62 event: 23609118 stream: 0
   [1] Running path 'dqmoffline_10_step'
   [2] Prefetching for module JetMonitor/'L1SingleJet200_Prommonitoring'
   [3] Prefetching for module ChainedJetCorrectorProducer/'ak4PFScoutL1FastL2L3ResidualCorrector'
   [4] Calling method for module L1FastjetCorrectorProducer/'ak4PFScoutL1FastjetCorrector'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: double
Looking for module label: hltScoutingPFPacker
Looking for productInstanceName: rho

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

2025.0000001

Failed RelVals-INPUT

136.7801136.7801_RunHLTPhy2017B_AOD/step2_RunHLTPhy2017B_AOD.log
136.7803136.7803_RunHLTPhy2017B_RAWAOD/step2_RunHLTPhy2017B_RAWAOD.log
1003.01003.0_RunMinBias2012A/step2_RunMinBias2012A.log

Expand to see more relval errors ...

…equence analogous to 'jetmetScoutingMonitorHLT' but w/o JECs

…jetmetScoutingNoJECsMonitorHLT' modules to run only with scouting DQM (the latter is to avoid crash with RelVals)

… also into online scouting DQM

…odules w/o JECs to avoid crash with RelVals

mmusich · 2026-03-02T07:15:26Z

+hlt

gabrielmscampos · 2026-03-02T12:20:20Z

+dqm

mmusich · 2026-03-09T20:17:04Z

@cms-sw/reconstruction-l2 your signature is expected here.
@etzovara do you plan a backport?

Moanwar · 2026-03-10T13:03:45Z

@cms-sw/reconstruction-l2 your signature is expected here. @etzovara do you plan a backport?

Noted from reconstruction-l2. I will check it asap and get back to you

etzovara · 2026-03-10T18:06:39Z

@mmusich yes, I would like to do backport. Can I already proceed with it?

patinkaew · 2026-03-10T19:01:38Z

sorry for answering instead, @mmusich. hope you don't mind.

@etzovara, given that all the tests pass, I think you can already open a backport PR so we can start the test for backport to 16_0_X. So please proceed with the backport :)

Moanwar · 2026-03-10T19:08:45Z

+1

cmsbuild · 2026-03-10T19:09:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

etzovara · 2026-03-10T20:55:37Z

sorry for answering instead, @mmusich. hope you don't mind.

@etzovara, given that all the tests pass, I think you can already open a backport PR so we can start the test for backport to 16_0_X. So please proceed with the backport :)

I thought I should do a backport to 16_1_X. Shall I also do it to 16_0_X?

patinkaew · 2026-03-10T21:03:25Z

I thought I should do a backport to 16_1_X. Shall I also do it to 16_0_X?

Master branch is at 16_1_X, so when this PR will be merged to 16_1_X.
Please open a backport to 16_0_X (data-taking) :).

ftenchini · 2026-03-11T11:55:51Z

+1

mmusich · 2026-03-20T12:03:30Z

Please open a backport to 16_0_X (data-taking) :).

is the backport available?

etzovara · 2026-03-20T12:09:24Z

Please open a backport to 16_0_X (data-taking) :).

is the backport available?

I'm proceeding with it right after the meeting

etzovara added 5 commits February 18, 2026 22:16

JetMonitor_cff/cfi.py: Adding trigger paths and options for Scouting …

447fc27

…trigger efficiency

JetMETPromptMonitoring_Client_cff.py: Defining namings of pltos and a…

2da4f87

…xis for Scouting jets

JetMonitor.cc: Adding part for scouting trigger efficiency calculatio…

8ffe6e1

…n (applying also JetID,JECs,MuonID muon isol)

Run3ScoutingPFJetIDSelectionFunctor.h: Updating Scouting JetID criteria

31311f8

JetMonitor.cc: fixes after code format checks + fixing MuonID criteria

77cb014

cmsbuild added this to the CMSSW_16_1_X milestone Feb 19, 2026

cmsbuild added reconstruction-pending dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 19, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 19, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 19, 2026

cmsbuild added tests-rejected and removed tests-started labels Feb 19, 2026

etzovara added 6 commits February 25, 2026 23:09

JetMETPromptMonitor_cff.py: Adding 'jetmetScoutingNoJECsMonitorHLT' s…

d22ade0

…equence analogous to 'jetmetScoutingMonitorHLT' but w/o JECs

HLTScoutingDqmOffline_cff.py: Adding 'jetmetScoutingMonitorHLT' and '…

d9fa7ab

…jetmetScoutingNoJECsMonitorHLT' modules to run only with scouting DQM (the latter is to avoid crash with RelVals)

ScoutingJetMonitoring_cff.py: Including scouting trigger efficiencies…

a15bf70

… also into online scouting DQM

JetMETPromptMonitor_cff.py: Adding 'jetmetScoutingNoJECsMonitorHLT' m…

5ae3209

…odules w/o JECs to avoid crash with RelVals

JetMonitor.cc: minor changes

a9b81e6

JetMonitor.cc: changes after running code-format

a5bd076

cmsbuild removed the tests-rejected label Feb 25, 2026

cmsbuild added hlt-approved and removed hlt-pending labels Mar 2, 2026

cmsbuild added dqm-approved and removed dqm-pending labels Mar 2, 2026

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Mar 10, 2026

cmsbuild added orp-approved and removed orp-pending labels Mar 11, 2026

cmsbuild merged commit de6e02e into cms-sw:master Mar 11, 2026
11 checks passed

etzovara mentioned this pull request Mar 24, 2026

[Backport] JME Offline DQM: adding trigger efficiency for scouting jets #50527

Merged

Conversation

etzovara commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 19, 2026

Uh oh!

cmsbuild commented Feb 19, 2026

Uh oh!

gabrielmscampos commented Feb 19, 2026

Uh oh!

cmsbuild commented Feb 19, 2026

Failed RelVals

Failed RelVals-INPUT

Uh oh!

mmusich commented Mar 2, 2026

Uh oh!

gabrielmscampos commented Mar 2, 2026

Uh oh!

mmusich commented Mar 9, 2026

Uh oh!

Moanwar commented Mar 10, 2026

Uh oh!

etzovara commented Mar 10, 2026

Uh oh!

patinkaew commented Mar 10, 2026

Uh oh!

Moanwar commented Mar 10, 2026

Uh oh!

cmsbuild commented Mar 10, 2026

Uh oh!

etzovara commented Mar 10, 2026

Uh oh!

patinkaew commented Mar 10, 2026

Uh oh!

ftenchini commented Mar 11, 2026

Uh oh!

Uh oh!

mmusich commented Mar 20, 2026

Uh oh!

etzovara commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

etzovara commented Feb 19, 2026 •

edited

Loading

cmsbuild commented Feb 19, 2026 •

edited

Loading