Skip to content

[EVO] Moved HGCSample to versioned namespace#50320

Merged
cmsbuild merged 1 commit intocms-sw:CMSSW_16_1_EVOLUTION_Xfrom
Dr15Jones:evo_HGCDigi
Mar 6, 2026
Merged

[EVO] Moved HGCSample to versioned namespace#50320
cmsbuild merged 1 commit intocms-sw:CMSSW_16_1_EVOLUTION_Xfrom
Dr15Jones:evo_HGCDigi

Conversation

@Dr15Jones
Copy link
Copy Markdown
Contributor

@Dr15Jones Dr15Jones commented Mar 5, 2026

PR description:

PR validation:

Code compiles.

resolves cms-sw/framework-team#1996

@Dr15Jones Dr15Jones changed the title Moved HGCSample to versioned namespace [EVO] Moved HGCSample to versioned namespace Mar 5, 2026
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 5, 2026

cms-bot internal usage

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

type evolution

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

assign core

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 5, 2026

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 5, 2026

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 5, 2026

A new Pull Request was created by @Dr15Jones for CMSSW_16_1_EVOLUTION_X.

It involves the following packages:

  • DataFormats/HGCDigi (simulation)

@Dr15Jones, @civanch, @kpedro88, @makortel, @mdhildreth, @smuzaffar can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @cseez, @denizsun, @hatakeyamak, @lgray, @missirol, @mmusich, @pfs, @rovere, @salimcerci, @sethzenz, @vandreev11 this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 5, 2026

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb563/51790/summary.html
COMMIT: 908867f
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-03-02-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50320/51790/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb563/51790/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb563/51790/git-merge-result

  • Static analyzer reported errors, please check

Failed RelVals

----- Begin Fatal Exception 05-Mar-2026 22:10:10 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 05-Mar-2026 22:20:04 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'edm::RangeMap<CSCDetId,edm::OwnVector<CSCSegment,edm::ClonePolicy<CSCSegment> >,edm::ClonePolicy<CSCSegment> >'
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 05-Mar-2026 22:14:20 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::HepMCProduct
  edm::Wrapper<edm::HepMCProduct>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  edm::HepMCProduct (read from input)

Missing dictionaries are associated with these branch names:

  edmHepMCProduct_generatorSmeared__RECOBEFMIX.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

Failed AddOn Tests

----- Begin Fatal Exception 05-Mar-2026 22:02:39 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664'
   Additional Info:
      [a] Attempted to open logical file /store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class reco::Photon::PflowIDVariables read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
   has the same version (=3) as the active class but a different checksum.
   You should update the version to ClassDef(reco::Photon::PflowIDVariables,4).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open the file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback.
      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664.
      [e] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664&tried=+1213xrootd-redic.pi.infn.it&xrdcl.requuid=d6516680-d3ef-4da9-956a-8fe392a59118
      [g] Problematic data server: cms-xrd-global.cern.ch:1094
      [h] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

@makortel
Copy link
Copy Markdown
Contributor

makortel commented Mar 5, 2026

ignore tests-rejected manual-override

Test failures will be addressed later

@makortel
Copy link
Copy Markdown
Contributor

makortel commented Mar 5, 2026

+core

@civanch
Copy link
Copy Markdown
Contributor

civanch commented Mar 6, 2026

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 6, 2026

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_1_EVOLUTION_X IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 8d467f1 into cms-sw:CMSSW_16_1_EVOLUTION_X Mar 6, 2026
7 of 9 checks passed
@Dr15Jones Dr15Jones deleted the evo_HGCDigi branch March 19, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants