TICL-barrel validation @ HLT#50588
Conversation
|
type ngt |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50588/48773
|
|
A new Pull Request was created by @bfonta for master. It involves the following packages:
@Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
bfonta
force-pushed
the
feature/hlt_ticl_barrel
branch
from
1a8bac5 to
e86618e
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50588/48774
|
|
Pull request #50588 was updated. @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
|
test parameters:
|
bfonta
force-pushed
the
feature/hlt_ticl_barrel
branch
from
e86618e to
bbc374d
Compare
|
@bfonta thanks for the updates, I have no further comments.
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50588/48951
|
|
Pull request #50588 was updated. @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
|
Pull request #50588 was updated. @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 16KB to repository HLT P2 Timing: chart Comparison SummarySummary:
|
|
+hlt
|
mmusich
left a comment
mmusich
left a comment
There was a problem hiding this comment.
just in case there are more edits.
|
@mmusich I noticed that It is still not clear why the small differences you point out occur. |
|
Pull request #50588 was updated. @Moanwar, @civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
|
please test |
|
+1 Size: This PR adds an extra 28KB to repository HLT P2 Timing: chart Comparison SummarySummary:
|
|
+1 |
|
+hlt |
wrong signature area? |
HAHAHAHAHAHA yes, I don't know what was in my head. |
|
+dqm |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
@mandrenguyen @ftenchini can we please merge this? Other PRs are in the queue. |
|
+1 |
7 participants
PR description:
Enables the validation of TICL-barrel at HLT as introduced in #47859 for the offline reconstruction. Logically follows #48565. The HLT configuration is now using the same parameters as used for the offline clustering.
Results are stored under
HLT/BarrelCalorimeters/BarrelValidator/.This PR does not include a "validation of the validation": I checked if the plots were created and that most of them were not empty, but I did not try to assess the correctness of the results, nor did I attempted to optimize CLUE's configuration at HLT.
PR validation:
Tested with the
34434.77_TTbar_14TeV+Run4D121_NGTScoutingworkflow:NEVENTS=100 cmsDriver.py TTbar_14TeV_TuneCP5_cfi -s GEN,SIM -n ${NEVENTS} --conditions auto:phase2_realistic_T35 --beamspot DBrealisticHLLHC --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry ExtendedRun4D121 --era \ Phase2C22I13M9 --relval 9000,100 --fileout file:step1.root cmsDriver.py step2 -s DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:NGTScouting,VALIDATION:@hltValidation --conditions auto:phase2_realistic_T35 --datatier GEN-SIM-DIGI-RAW,DQMIO -n ${NEVENTS} --even\ tcontent FEVTDEBUGHLT,DQMIO --geometry ExtendedRun4D121 --era Phase2C22I13M9 --procModifiers ngtScouting,ticl_barrel --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 --filein file:st\ ep1.root --fileout file:step2.root cmsDriver.py step3 -s HARVESTING:@hltValidation --conditions auto:phase2_realistic_T35 --mc --geometry ExtendedRun4D121 --scenario pp --filetype DQM --era Phase2C22I13M9 --procModifiers ngtScouting,ticl_barre\ l -n ${NEVENTS} --filein file:step2_inDQM.root --fileout file:step3.rootNote: The configuration of CLUE at HLT was set to match the configuration currently in place for the offline reconstruction, since the configuration so far had not been verified. The configuration at HLT can be optimized at a later time. To give an example, the kappa value used for the HCAL led to the almost full absence of clusters in HCAL