Skip to content

hlt-p2-timing: Drop live output from runHLTTiming.sh#50867

Closed
smuzaffar wants to merge 1 commit intocms-sw:masterfrom
smuzaffar:fix-hlt-p2-timing-drop-live-output
Closed

hlt-p2-timing: Drop live output from runHLTTiming.sh#50867
smuzaffar wants to merge 1 commit intocms-sw:masterfrom
smuzaffar:fix-hlt-p2-timing-drop-live-output

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

Thsi PR proposes to drop the live output (i.e. tail -f <logfile>) from the runHLTTiming.sh script. Locally running the change did not show any errors

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

cms-bot internal usage

@smuzaffar
Copy link
Copy Markdown
Contributor Author

enable hlt_p2_timing

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50867/49222

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@slava77
Copy link
Copy Markdown
Contributor

slava77 commented May 4, 2026

@smuzaffar
is this supposed to fix errors like in #50856 ? (If yes, I was going to suggest to run the timing test there with this PR)

@smuzaffar
Copy link
Copy Markdown
Contributor Author

Yes, this change should fix those errors

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b52b4/53045/summary.html
COMMIT: 08d1a91
CMSSW: CMSSW_17_0_X_2026-05-03-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50867/53045/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4187168
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4187142
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Copy Markdown
Contributor Author

@mmusich , this change should fix the failing hlt-p2-timing tests in IBs and PRs

@smuzaffar
Copy link
Copy Markdown
Contributor Author

hold

I have open #50868 which should keep the live output. If that works then I would like to close this PR in favor of #50868

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label May 4, 2026
@smuzaffar
Copy link
Copy Markdown
Contributor Author

closing it in favor of #50868

@smuzaffar smuzaffar closed this May 4, 2026
@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented May 7, 2026

-hlt

  • for the record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants