Skip to content

Fix hlt-p2-timing: properly wait and comsume the background processed#50868

Merged
cmsbuild merged 2 commits intocms-sw:masterfrom
smuzaffar:hlt-p2-timing-test-fix
May 5, 2026
Merged

Fix hlt-p2-timing: properly wait and comsume the background processed#50868
cmsbuild merged 2 commits intocms-sw:masterfrom
smuzaffar:hlt-p2-timing-test-fix

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

Thsi change keeps the live output of hlt-p2-timing test but also properly wait forback-ground process and consume their exit code. This should fix the failing hlt-p2-timing test in IBs and PRs

If worked fine then this should replace the change in #50867

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50868/49224

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50868/49226

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

Pull request #50868 was updated. @Martin-Grunewald, @mmusich can you please check and sign again.

@smuzaffar
Copy link
Copy Markdown
Contributor Author

enable hlt_p2_timing

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@smuzaffar
Copy link
Copy Markdown
Contributor Author

@cms-sw/hlt-l2 , this fixes the failing HLT P2 Timing jobs in IBs and PRs.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f91f76/53053/summary.html
COMMIT: 6709baf
CMSSW: CMSSW_17_0_X_2026-05-04-1100/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50868/53053/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4187168
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4187123
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented May 5, 2026

+hlt

  • thanks for the fix

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 5, 2026

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 5ff6534 into cms-sw:master May 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants