Skip to content

Fix hlt-p2-timing: properly wait and comsume the background processed #50868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
May 5, 2026
+10 −5
Merged

Fix hlt-p2-timing: properly wait and comsume the background processed #50868

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85a696b
Fix hlt-p2-timing: properly wait and comsume the background processed
smuzaffar May 4, 2026
6709baf
make sure to kill the benchmark job on failure
smuzaffar May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions HLTrigger/Configuration/python/HLT_75e33/test/runHLTTiming.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,14 @@ run_benchmark() {

local PID=$!

# Ensure cleanup on failure
trap 'kill $PID 2>/dev/null || true' EXIT

# Live output
tail -f "$TMP_LOG_FILE" &
tail -f --pid=$PID "$TMP_LOG_FILE" &
local TAIL_PID=$!

trap "kill $PID $TAIL_PID 2>/dev/null" EXIT

while ps -p $PID > /dev/null; do
while kill -0 $PID 2>/dev/null; do

# Memory
mem=$(get_current_total_gpu_mem)
Expand Down Expand Up @@ -231,7 +232,11 @@ run_benchmark() {
sleep $MONITOR_INTERVAL
done

kill $TAIL_PID 2>/dev/null
wait $PID

#tail should already exit due to --pid=$PID
wait $TAIL_PID 2>/dev/null || true

mv "$TMP_LOG_FILE" "${logdir}/output.log"

# Compute mean
Expand Down