testingfarm: move environment constraints into fmf plan - #9265
Conversation
Declare arch, compose (Fedora-44), virtualization support, and hardware requirements (memory >= 4 GB, disk >= 60 GiB) in plans/job-runner.fmf instead of hard-coding them in the API request. Drop the compose parameter from submit_job() and remove the explicit pipeline timeout, relying on Testing Farm defaults.
| disk: | ||
| - size: ">= 60 GiB" | ||
| virtualization: | ||
| #is-virtualized: true |
There was a problem hiding this comment.
this definitely needs to be true. it's the most important part...
There was a problem hiding this comment.
it should be fine. as you are asking to support virtualization, not that machine itself is virtual and support nested virt
| hardware: | ||
| memory: ">= 4 GB" | ||
| disk: | ||
| - size: ">= 60 GiB" |
There was a problem hiding this comment.
I'd definitely want @jelly to weigh in on this. We've had some issues in the past...
There was a problem hiding this comment.
these constraints could be dangerous, to not be able to select any machine, but I think it should be fine, in fact I've never used disc size requirements inside TF. But We'll see.
The Testing Farm API validates arch at submission time and rejects requests without it, even when arch is declared in the fmf plan.
Like arch, the compose must be specified in the API request — Testing Farm uses it to select the OS image and does not fall back to the fmf plan's provision.image. Default to Fedora-44 to match the fmf plan.
Testing Farm does its own machine provisioning and ignores the how field. Having how: virtual caused tmt to attempt spinning up a nested VM inside the Testing Farm machine, stalling the queue.
Removing the disk size constraint to reduce restrictions on available Testing Farm machines and avoid stalling in the queue.
scheduled from command line
seems to be able to run : https://artifacts.osci.redhat.com/testing-farm/616da0f9-4f3b-4b8b-a516-ea1b9a1bd478/work-job-runnerx5xiq0kf/tmt-run.log https://artifacts.osci.redhat.com/testing-farm/616da0f9-4f3b-4b8b-a516-ea1b9a1bd478/ Various options can be places inside FMF plan file some limitations
|
3 participants
Env constraints should be inside FMF plan file instead of hard-coding them in the API request, it is intended to override these values inside plan.
Drop these parameters from submit_job() and remove the explicit pipeline timeout, relying on Testing Farm defaults.