Skip to content

testingfarm: move environment constraints into fmf plan #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jscotka wants to merge 5 commits into
base: main
Choose a base branch
from
Open

testingfarm: move environment constraints into fmf plan #9265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19bd344
testingfarm: move environment constraints into fmf plan
jscotkahat Jul 9, 2026
b15fa8f
testingfarm: keep arch in API request, required by Testing Farm
jscotkahat Jul 9, 2026
11d8447
testingfarm: restore compose parameter, required by Testing Farm API
jscotkahat Jul 9, 2026
ba18d73
plans/job-runner: drop provision.how from fmf plan
jscotkahat Jul 9, 2026
a646fd6
plans/job-runner: drop disk size hardware requirement
jscotkahat Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions lib/aio/testingfarm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,13 @@ async def submit_job(
job: JobSpecification | JsonObject, # TODO: PEP 728
*,
git_url_ref: tuple[str, str] | None = None,
compose: str = 'Fedora-Rawhide',
) -> str:
"""Submit a job to Testing Farm for remote execution.

Args:
ctx: JobContext with configuration (will be serialized)
job: Job specification as JSON object
git_url_ref: Git repository URL and ref (default: from @{upstream})
compose: Fedora compose to use (default: Fedora-Rawhide)

Returns:
Testing Farm request ID
Expand Down Expand Up @@ -142,27 +140,14 @@ async def submit_job(
},
'environments': [
{
'arch': 'x86_64',
'os': {'compose': compose},
'variables': {
'JOB_JSON': job_json,
},
'secrets': {
'JOB_RUNNER_CONFIG_JSON': config_json,
},
'hardware': {
'virtualization': {
'is-virtualized': True,
'is-supported': True,
}
},
}
],
'settings': {
'pipeline': {
'timeout': 120,
}
},
}

url = f'{self.api_url}/requests'
Expand Down
14 changes: 13 additions & 1 deletion plans/job-runner.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
summary: Run job-runner task remotely
provision:
how: virtual
arch: x86_64
image: Fedora-44
hardware:
memory: ">= 4 GB"
disk:
- size: ">= 60 GiB"

@allisonkarlitskaya allisonkarlitskaya Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd definitely want @jelly to weigh in on this. We've had some issues in the past...

@jscotka jscotka Jul 9, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these constraints could be dangerous, to not be able to select any machine, but I think it should be fine, in fact I've never used disc size requirements inside TF. But We'll see.

virtualization:
#is-virtualized: true

@allisonkarlitskaya allisonkarlitskaya Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this definitely needs to be true. it's the most important part...

@jscotka jscotka Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be fine. as you are asking to support virtualization, not that machine itself is virtual and support nested virt

is-supported: true

prepare:
how: install
package:
Expand All @@ -16,4 +28,4 @@ execute:
/job-runner:
summary: Run job-runner task
test: ../job-runner json "$JOB_JSON"
duration: 2h
duration: 4h
Loading