Skip to content

[Stack 1/25] Test cleanup: consolidate Clojure comparison tests #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jucor merged 3 commits into from
Mar 19, 2026
Merged

[Stack 1/25] Test cleanup: consolidate Clojure comparison tests #2417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecd5b9b
Consolidate Clojure comparison tests into test_legacy_clojure_regress…
jucor Jan 6, 2026
9f6f0a5
Constrain xfail markers to AssertionError with strict=True
jucor Mar 10, 2026
d62bb68
CI: run Delphi Python tests on PRs targeting jc/** branches
jucor Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/python-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,17 @@ name: Delphi Python Tests

on:
push:
branches: &branches [ edge, stable ]
branches: [ edge, stable ]
paths: &paths
- 'delphi/**/*.py'
- 'delphi/requirements*.txt'
- 'delphi/Dockerfile'
- '.github/workflows/python-ci.yml'
pull_request:
branches: *branches
branches:
- edge
- stable
- 'jc/**'
paths: *paths

jobs:
Expand Down
48 changes: 0 additions & 48 deletions delphi/tests/test_golden_data.py
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions delphi/tests/test_legacy_clojure_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def test_pca_components_match_clojure(self, conversation_data):
check.less_equal(norm_angle_deg, 10.0,
f"PC{i+1} angle difference should be ≤10° (got {norm_angle_deg:.2f}°)")

@pytest.mark.skip(reason="Clojure regression tests not yet fully implemented - clustering algorithms may differ")
@pytest.mark.xfail(raises=AssertionError, strict=True, reason="Clojure regression tests not yet fully implemented - clustering algorithms may differ")
def test_group_clustering(self, conversation_data):
"""
Test that group clustering matches the Clojure implementation.
Expand Down Expand Up @@ -334,7 +334,7 @@ def test_group_clustering(self, conversation_data):
check.greater_equal(jaccard_similarity, 70.0,
f"Matched groups (Py:{py_idx}/Clj:{clj_idx}) should have ≥70% Jaccard similarity (got {jaccard_similarity:.1f}%)")

@pytest.mark.skip(reason="Clojure regression tests not yet fully implemented - comment priorities may differ")
@pytest.mark.xfail(raises=AssertionError, strict=True, reason="Clojure regression tests not yet fully implemented - comment priorities may differ")
def test_comment_priorities(self, conversation_data):
"""
Test that comment priorities match the Clojure implementation.
Expand Down
Loading