[Stack 1/25] Test cleanup: consolidate Clojure comparison tests#2417
Merged
[Stack 1/25] Test cleanup: consolidate Clojure comparison tests#2417
Conversation
This was referenced Mar 5, 2026
jucor
force-pushed
the
jc/pca_test_cleanup
branch
from
05eaeae to
359a2dd
Compare
…ion.py - Delete test_golden_data.py: redundant with test_legacy_clojure_regression.py - Change @Skip to @xfail for test_group_clustering and test_comment_priorities so they run and document expected failures rather than being silently skipped 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jucor
force-pushed
the
jc/pca_test_cleanup
branch
from
359a2dd to
ecd5b9b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up legacy Clojure comparison testing by removing a redundant golden-data test and switching two placeholder “not implemented yet” checks from being skipped to being tracked as expected failures.
Changes:
- Convert two legacy Clojure comparison tests from
@pytest.mark.skipto@pytest.mark.xfail. - Delete
test_golden_data.py(redundant golden-data comparison test).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
delphi/tests/test_legacy_clojure_regression.py |
Switches two legacy Clojure comparison tests to xfail so they execute and report expected failures. |
delphi/tests/test_golden_data.py |
Removes a redundant xfailed golden-data comparison test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Unconstrained xfail swallows any exception (KeyError, AttributeError, etc.), masking real regressions. Adding raises=AssertionError ensures only assertion failures are treated as expected, and strict=True alerts when tests start passing. Addresses GitHub Copilot review feedback on PR #2417. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jucor
changed the title
jucor
changed the title
5 tasks
jucor
changed the title
jucor
changed the title
jucor
changed the title
jucor
changed the title
ballPointPenguin
approved these changes
Mar 14, 2026
jucor
changed the title
Stacked PRs target jc/* branches, not edge/stable, so the Python CI was not running on them. Add jc/** to pull_request.branches so stack PRs get test coverage. Push triggers remain edge/stable only. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jucor
changed the title
Delphi Coverage Report
|
jucor
changed the title
jucor
changed the title
jucor
changed the title
whilo
approved these changes
Mar 19, 2026
jucor
changed the title
jucor
added a commit
that referenced
this pull request
Mar 19, 2026
Unconstrained xfail swallows any exception (KeyError, AttributeError, etc.), masking real regressions. Adding raises=AssertionError ensures only assertion failures are treated as expected, and strict=True alerts when tests start passing. Addresses GitHub Copilot review feedback on PR #2417. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jucor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-sklearn cleanup:
test_legacy_clojure_regression.py, delete redundanttest_golden_data.py@skipmarkers to@xfailfor tests with known differencesTest plan
🤖 Generated with Claude Code