Fix #1851: Sort open groupchats alphabetically when grouped by domain#3983
Open
cj-l920 wants to merge 1 commit intoconversejs:masterfrom
Open
Fix #1851: Sort open groupchats alphabetically when grouped by domain#3983cj-l920 wants to merge 1 commit intoconversejs:masterfrom
cj-l920 wants to merge 1 commit intoconversejs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary
Fixes #1851: Open Groupchats not sorted in any order
When the
muc_grouped_by_domainconfiguration option is enabled, rooms within each domain group were not being sorted alphabetically. This made it difficult for users to find specific groupchats in the list.Solution Approach
Added alphabetical sorting to the
tplRoomDomainGroupListfunction insrc/plugins/roomslist/templates/roomslist.js.The fix ensures that:
Changes Made
tplRoomDomainGroupList()to sort rooms alphabetically usinggetDisplayName()toLowerCase()) for consistent orderingTest Evidence
getRoomsToShow()in view.jsExample
Before (random order within domain):
example.com
Zebra Chat
Alpha Room
Beta Group
After (alphabetically sorted):
example.com
Alpha Room
Beta Group
Zebra Chat
Fixes #1851