Skip to content

Fix #1851: Sort open groupchats alphabetically when grouped by domain #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cj-l920 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #1851: Sort open groupchats alphabetically when grouped by domain #3983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/plugins/roomslist/templates/roomslist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,15 @@ function tplRoomDomainGroup (el, domain, rooms) {
* @param {MUC[]} rooms
*/
function tplRoomDomainGroupList (el, rooms) {
// The rooms should stay sorted as they are iterated and added in order
// Sort rooms alphabetically by display name first
const sorted_rooms = [...rooms].sort((a, b) => {
const nameA = a.getDisplayName().toLowerCase();
const nameB = b.getDisplayName().toLowerCase();
return nameA <= nameB ? -1 : 1;
});

const grouped_rooms = new Map();
for (const room of rooms) {
for (const room of sorted_rooms) {
const roomdomain = room.get('jid').split('@').at(-1).toLowerCase();
if (grouped_rooms.has(roomdomain)) {
grouped_rooms.get(roomdomain).push(room);
Expand Down