feat: add Kotlin/Scala glue file support and fix two bugs#140
Open
marton78 wants to merge 1 commit into
Open
Conversation
- Add kotlin (.kt/.kts) and scala (.scala) to glueExtByLanguageName - Fix: reindex crash when DidChangeConfiguration sends null/malformed settings (params.settings was blindly cast to Settings, causing undefined.reduce() if features/glue were missing — seen with Zed) - Fix: wasmBasePath resolved incorrectly when npm hoists @cucumber/language-service; use require.resolve() instead of the hardcoded __dirname/../node_modules path - Point @cucumber/language-service at marton78/language-service fork Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
marton78
force-pushed
the
kotlin-support
branch
2 times, most recently
from
f8e69f8 to
ec6b4d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kotlin(.kt/.kts) andscala(.scala) toglueExtByLanguageNameso the server discovers step definitions in those filesDidChangeConfigurationsendsnull/malformed settings —params.settingswas blindly cast toSettings, causingundefined.reduce()iffeatures/gluewere missing (observed with Zed)wasmBasePathresolved incorrectly when npm hoists@cucumber/language-service; now usesrequire.resolve()instead of the hardcoded__dirname/../node_modulespathDependency chain
This PR is a part of two, adding Kotlin support:
cucumber/language-service#304 — Kotlin parsing (merge first)Test plan
.ktand.ktsfiles are indexed as glue files.scalafiles are indexed as glue filesDidChangeConfigurationwith null/missing settingswasmBasePathresolves correctly when@cucumber/language-serviceis hoisted by npm