Unused variable assignment and use#6
Open
Tomas2h wants to merge 1 commit into
Open
Conversation
…his variable could cause a 1/0 sometimes
TCatshoek
force-pushed
the
RemoveAssigmentInCamera
branch
from
65fb23f to
ef72c0d
Compare
|
How certain are we this doesn't break anything? |
|
I dont think this is properly tested yet, we should do that first before submitting the PR to Phaser |
|
Agreed, lets not include this for now, until we're sure it is ok. |
|
why would it break anything? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes (delete as applicable):
Describe the changes below:
removed unused assignment and extended condition as 1/0 gives an inverse of infinity