Skip to content

Unused variable assignment and use #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tomas2h wants to merge 1 commit into
base: FixTechDebt
Choose a base branch
from
Open

Unused variable assignment and use #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/cameras/2d/Camera.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,8 +480,6 @@ var Camera = new Class({
var culledObjects = this.culledObjects;
var length = renderableObjects.length;

determinant = 1 / determinant;

culledObjects.length = 0;

for (var index = 0; index < length; ++index)
Expand Down Expand Up @@ -556,8 +554,6 @@ var Camera = new Class({
var cameraH = this.height;
var length = interactiveObjects.length;

determinant = 1 / determinant;

var culledObjects = [];

for (var index = 0; index < length; ++index)
Expand Down Expand Up @@ -615,7 +611,7 @@ var Camera = new Class({

if (!determinant)
{
return tiles;
return tilemap.tiles;
}

var mve = cameraMatrix[4];
Expand All @@ -634,8 +630,6 @@ var Camera = new Class({
var scrollFactorX = tilemap.scrollFactorX;
var scrollFactorY = tilemap.scrollFactorY;

determinant = 1 / determinant;

culledObjects.length = 0;

for (var index = 0; index < length; ++index)
Expand Down Expand Up @@ -765,7 +759,7 @@ var Camera = new Class({
/* First Invert Matrix */
var determinant = (mva * mvd) - (mvb * mvc);

if (!determinant)
if (!determinant || determinant === 0)
{
output.x = x;
output.y = y;
Expand Down Expand Up @@ -1323,7 +1317,7 @@ var Camera = new Class({
{
this._shakeOffsetX = (Math.random() * intensity * this.width * 2 - intensity * this.width) * this.zoom;
this._shakeOffsetY = (Math.random() * intensity * this.height * 2 - intensity * this.height) * this.zoom;

if (this.roundPixels)
{
this._shakeOffsetX |= 0;
Expand Down