fix(utils): Add null check to parseCrossOriginStylesheet, closes #5074#5075
Open
dcbroad3 wants to merge 3 commits intodequelabs:developfrom
Open
fix(utils): Add null check to parseCrossOriginStylesheet, closes #5074#5075dcbroad3 wants to merge 3 commits intodequelabs:developfrom
dcbroad3 wants to merge 3 commits intodequelabs:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses axe-core issue #5074 by preventing parseCrossOriginStylesheet from attempting to fetch a stylesheet when the provided href/URL is nullish, avoiding erroneous network requests like "null".
Changes:
- Add a nullish check in
parseCrossOriginStylesheetto return early whenurl == null. - Add a unit test intended to cover the nullish-URL case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/core/utils/parse-crossorigin-stylesheet.js | Adds early return when the cross-origin stylesheet URL is nullish. |
| test/core/utils/parse-crossorigin-stylesheet.js | Adds coverage for the nullish-URL behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| isCrossOrigin | ||
| ) { | ||
| if (url == null) { | ||
| return Promise.resolve(); |
Author
There was a problem hiding this comment.
I am following the pattern of the early return in parseSameOriginStylesheet if rules is falsy, but let me know if a different result should be returned (or if the function should do an early reject instead?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a null href is passed to
parseCrossOriginStylesheet, the function will currently convert that to the string "null" and attempt to load that href. This PR adds a null check so that the function instead returns early if a nullish href is passed, similar to howparseSameOriginStylesheetreturns early if a sheet includes no rules.Closes:
#5074