Skip to content

fix(utils): Add null check to parseCrossOriginStylesheet, closes #5074 #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcbroad3 wants to merge 3 commits into
base: develop
Choose a base branch
from
+35 −0
Open

fix(utils): Add null check to parseCrossOriginStylesheet, closes #5074 #5075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74cfa95
Add null check to parseCrossOriginStylesheet
dcbroad3 Apr 14, 2026
2cacb8c
Add test
dcbroad3 Apr 14, 2026
64c1e70
Improve test
dcbroad3 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/core/utils/parse-crossorigin-stylesheet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ function parseCrossOriginStylesheet(
importedUrls,
isCrossOrigin
) {
if (url == null) {
return Promise.resolve();
Copy link
Copy Markdown
Author

@dcbroad3 dcbroad3 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am following the pattern of the early return in parseSameOriginStylesheet if rules is falsy, but let me know if a different result should be returned (or if the function should do an early reject instead?)

}

/**
* Add `url` to `importedUrls`
*/
Expand Down
31 changes: 31 additions & 0 deletions test/core/utils/parse-crossorigin-stylesheet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,35 @@ describe('axe.utils.parseCrossOriginStylesheet', function () {
done();
});
});

it('returns empty results when url is nullish', function (done) {
this.timeout(axe.constants.preload.timeout + 1000);

var importUrl = null;
var options = {
rootNode: document,
shadowId: undefined,
convertDataToStylesheet: convertDataToStylesheet,
rootIndex: 1
};
var priority = [1, 0];
var importedUrls = [];
var isCrossOriginRequest = true;

axe.utils
.parseCrossOriginStylesheet(
importUrl,
options,
priority,
importedUrls,
isCrossOriginRequest
)
.then(function (data) {
assert.isUndefined(data);
done();
})
.catch(function (err) {
done(err);
});
});
});