Skip to content

#1869: Improve windows helper to search windows registry#1876

Open
jakozian wants to merge 12 commits intodevonfw:mainfrom
jakozian:feature/#1869-improve-windows-helper-to-search-windows-registry
Open

#1869: Improve windows helper to search windows registry#1876
jakozian wants to merge 12 commits intodevonfw:mainfrom
jakozian:feature/#1869-improve-windows-helper-to-search-windows-registry

Conversation

@jakozian
Copy link
Copy Markdown
Contributor

@jakozian jakozian commented Apr 29, 2026

This PR fixes #1869

Implemented changes:

  • Add methods to search for DisplayVersion, DisplayIcon, InstallLocation and UninstallString in common registry paths for an application.
  • Add tests

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 29, 2026
@jakozian jakozian self-assigned this Apr 29, 2026
@jakozian jakozian added internal Nothing to be added to CHANGELOG, only internal story windows specific for Microsoft Windows OS labels Apr 29, 2026
@jakozian jakozian moved this from 🆕 New to 🏗 In progress in IDEasy board Apr 29, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 29, 2026

Coverage Report for CI Build 25431217639

Coverage decreased (-0.03%) to 70.703%

Details

  • Coverage decreased (-0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 21 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

21 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/os/WindowsHelperImpl.java 19 61.76%
com/devonfw/tools/ide/version/VersionSegment.java 2 88.19%

Coverage Stats

Coverage Status
Relevant Lines: 15431
Covered Lines: 11373
Line Coverage: 73.7%
Relevant Branches: 6892
Covered Branches: 4410
Branch Coverage: 63.99%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

@hohwille hohwille moved this from 🏗 In progress to Team Review in IDEasy board Apr 30, 2026
Copy link
Copy Markdown
Contributor

@MarvMa MarvMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a really easy to read PR following the KISS principle, which I personally appreciate a lot 👍 I left some comments regarding minor changes. I have been more critical since that has been the desired task. But the coments are just related to minor changes in code-style regarding the coding-conventions of IDEasy.

Comment thread cli/src/main/java/com/devonfw/tools/ide/os/WindowsHelper.java
Comment thread cli/src/main/java/com/devonfw/tools/ide/os/WindowsHelperImpl.java Outdated
Comment thread cli/src/test/java/com/devonfw/tools/ide/os/WindowsHelperMock.java Outdated
@jakozian jakozian moved this from Team Review to 👀 In review in IDEasy board May 7, 2026
@jakozian jakozian requested a review from hohwille May 7, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Nothing to be added to CHANGELOG, only internal story windows specific for Microsoft Windows OS

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Improve WindowsHelper to search in windows registry

4 participants