php8 support - #1
Open
janalwin wants to merge 3 commits into
Open
Conversation
jantuitman
reviewed
Jan 7, 2021
| ], | ||
| "require": { | ||
| "php": "^7.2", | ||
| "php": "^7.2 || ^8.0", |
There was a problem hiding this comment.
dat was dus alles? 😄
ik denk wel dat we een PR bij hun ook moeten doen want ik zie dat de repo recente commits heeft. dus als we lang op een fork blijven raken we out of date met swagger.
Author
There was a problem hiding this comment.
Ja ik ga wel even een PR indienen. Ik heb wat wijzigingen uit hun eigen PR voor PHP8 overgenomen
Author
There was a problem hiding this comment.
IK laat deze branch voorlopig nog even bestaan. Dan is het duidelijk dat we nog niet een definitieve oplossing hebben
jantuitman
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.