Skip to content

php8 support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janalwin wants to merge 3 commits into
base: 6.x
Choose a base branch
from
Open

php8 support #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddc3961
php8 support
janalwin Jan 7, 2021
19150f4
adjust symfony/yaml version
janalwin Jan 7, 2021
a455644
adjusted required yaml versions
janalwin Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ matrix:
env: CACHE_NAME=SWAGGER
- php: 7.2
env: SWAGGER_VERSION=3.0 CACHE_NAME=OPEN_API REPORT_TESTS_COVERAGE=1
- php: 8.0
cache:
directories:
- "$HOME/.composer/cache"
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
}
],
"require": {
"php": "^7.2",
"php": "^7.2 || ^8.0",

@jantuitman jantuitman Jan 7, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dat was dus alles? 😄
ik denk wel dat we een PR bij hun ook moeten doen want ik zie dat de repo recente commits heeft. dus als we lang op een fork blijven raken we out of date met swagger.

@janalwin janalwin Jan 7, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja ik ga wel even een PR indienen. Ik heb wat wijzigingen uit hun eigen PR voor PHP8 overgenomen

@janalwin janalwin Jan 7, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IK laat deze branch voorlopig nog even bestaan. Dan is het duidelijk dat we nog niet een definitieve oplossing hebben

"laravel/framework": "^6.0",
"zircote/swagger-php": "~2.0|3.*",
"swagger-api/swagger-ui": "^3.0",
"symfony/yaml": "^4.1"
"symfony/yaml": "^4.1 || ^5.0"
},
"require-dev": {
"phpunit/phpunit": "8.*",
Expand Down