Fix import for DART in XGBoost 3.3 and 3.4 - #688
Merged
Conversation
chyunsu3
commented
Aug 22, 2026
| } | ||
|
|
||
| bool GradientBoosterHandler::EndObject() { | ||
| if (name == "dart" && !weight_drop.empty()) { |
Collaborator
Author
There was a problem hiding this comment.
XGBoost 3.3 no longer specifies a separate "dart" booster type for DART.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mainline #688 +/- ##
============================================
- Coverage 84.70% 84.39% -0.32%
============================================
Files 75 75
Lines 6860 6862 +2
Branches 557 557
============================================
- Hits 5811 5791 -20
- Misses 1049 1071 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@trivialfis Can you review? |
trivialfis
approved these changes
Aug 23, 2026
chyunsu3
added a commit
to chyunsu3/treelite
that referenced
this pull request
Aug 25, 2026
* Fix import for DART in XGBoost 3.4 * Fix import for DART in XGBoost 3.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #668