Skip to content

Fix import for DART in XGBoost 3.3 and 3.4 #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chyunsu3 merged 2 commits into from
Aug 23, 2026
Merged

Fix import for DART in XGBoost 3.3 and 3.4 #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c05f45
Fix import for DART in XGBoost 3.4
chyunsu3 Aug 22, 2026
d4ffed3
Fix import for DART in XGBoost 3.3
chyunsu3 Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/model_loader/detail/xgboost_json/delegated_handler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,8 @@ bool GBTreeModelHandler::StartArray() {
return (push_key_handler<RegTreeArrayHandler, std::vector<ParsedRegTreeParams>>(
"trees", reg_tree_params, *output.builder)
|| push_key_handler<ArrayHandler<int>, std::vector<int>>("tree_info", output.tree_info)
|| push_key_handler<ArrayHandler<float>, std::vector<float>>(
"weight_drop", output.weight_drop)
|| push_key_handler<IgnoreHandler>("iteration_indptr"));
}

Expand Down Expand Up @@ -546,7 +548,7 @@ bool GBTreeModelHandler::EndObject() {
}

bool GBTreeModelHandler::is_recognized_key(std::string const& key) {
return key == "trees" || key == "tree_info" || key == "gbtree_model_param"
return key == "trees" || key == "tree_info" || key == "gbtree_model_param" || key == "weight_drop"
|| key == "iteration_indptr" || key == "cats";
}

Expand Down Expand Up @@ -710,7 +712,7 @@ bool GradientBoosterHandler::StartArray() {
}

bool GradientBoosterHandler::EndObject() {
if (name == "dart" && !weight_drop.empty()) {

@chyunsu3 chyunsu3 Aug 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XGBoost 3.3 no longer specifies a separate "dart" booster type for DART.

if (!weight_drop.empty()) {
TREELITE_CHECK_EQ(output.size_leaf_vector, 1)
<< "Dart with vector-leaf output is not yet supported";
output.weight_drop = weight_drop;
Expand Down
1 change: 0 additions & 1 deletion tests/python/test_xgboost_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ def test_xgb_nonlinear_objective(
num_boost_round=integers(min_value=5, max_value=20),
)
@settings(**standard_settings())
@pytest.mark.xfail(reason="https://github.com/dmlc/treelite/issues/668")
def test_xgb_dart(dataset, model_format, num_boost_round):
# pylint: disable=too-many-locals
"""Test XGBoost DART model with dummy data"""
Expand Down
Loading