🪲 BUG-#63: Wire Agent.on_request in serve.py - #66
Merged
Conversation
FernandoCelmer
commented
Aug 16, 2026
FernandoCelmer
left a comment
FernandoCelmer
left a comment
Member
Author
There was a problem hiding this comment.
🔍 Code Review
Code issues found: 1
| # | Severity | Comment |
|---|---|---|
| 1 | [Suggestion] | Missing test for chat/request notification |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pycodeloop/cli/serve.py— Wires `agent.on_request`, forwarding it as a `chat/request` notification (`{messageCount, toolCount}`), mirroring how `run`/`chat` use the same hook for their "N msg in context, M tools available…" status line.Motivation and Context
`Agent.on_request` is called once per turn right before the provider call and is already wired in `cli/flow.py` (terminal
run) and `cli/chat.py` (interactive TUI), but never in `serve.py` — the only entry point the VSCode plugin talks to. It's a display-only hook (no message-loss impact on its own — the compaction path this was originally flagged against is already fixed independently in #65, since `_compact()` now reads via `session.history()` directly), but leaving it unwired was inconsistent with every other CLI entry point exposing the same signal to its client.Closes #63.
Types of changes
Checklist