Skip to content

🪲 BUG-#63: Wire Agent.on_request in serve.py #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FernandoCelmer merged 2 commits into from
Aug 16, 2026
Merged

🪲 BUG-#63: Wire Agent.on_request in serve.py #66

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c6fe12
🪲 BUG-#63: Wire agent.on_request in serve, forward as chat/request
FernandoCelmer Aug 16, 2026
c1d286c
❤️ TEST-#63: Assert chat/request notification is emitted on chat/send
FernandoCelmer Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pycodeloop/cli/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ def _respond_error(self, request_id, code: int, message: str) -> None:
def _wire_callbacks(self) -> None:
agent = self.flow.agent

def on_request(message_count: int, tool_count: int) -> None:
self._notify(
Comment thread
FernandoCelmer marked this conversation as resolved.
"chat/request",
{"messageCount": message_count, "toolCount": tool_count},
)

def on_text_delta(delta: str) -> None:
self._notify("chat/textDelta", {"delta": delta})

Expand Down Expand Up @@ -135,6 +141,7 @@ def confirm(name: str, preview: str) -> bool | str:
finally:
self._confirm_waiters.pop(request_id, None)

agent.on_request = on_request
agent.on_text_delta = on_text_delta
agent.on_turn_end = on_turn_end
agent.on_tool_call = on_tool_call
Expand Down
Loading