[tools] Simplify the creation of the list of frameworks a bit. by rolfbjarne · Pull Request #25618 · dotnet/macios

rolfbjarne · 2026-06-02T15:15:21Z

We don't need to know whether we're building for a simulator or device when
creating the list of frameworks, because now it's possible to specify
different values for simulator vs device.

This makes it possible to simplify the code a little bit.

Most of this is indentation changes, so it's easier to review if hiding whitespace changes.

We don't need to know whether we're building for a simulator or device when creating the list of frameworks, because now it's possible to specify different values for simulator vs device. This makes it possible to simplify the code a little bit. Most of this is indentation changes, so it's easier to review if hiding whitespace changes.

Copilot

Pull request overview

This PR refactors framework list retrieval in the tooling code, aiming to remove the need to know whether the current build is for simulator vs device when constructing the frameworks list (by encoding simulator/device availability per framework entry instead).

Changes:

Replaced the iOS frameworks getter method with a lazily-initialized iOSFrameworks property.
Introduced TryGetFrameworks (ApplePlatform, out Frameworks) and updated a few internal callers to use it.
Refactored Mac Catalyst framework initialization to build from the iOS list and then apply Catalyst-specific adjustments.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
tools/common/Frameworks.cs	Refactors iOS + Mac Catalyst framework lists and replaces `GetFrameworks` with a `TryGetFrameworks` pattern.
tools/common/Driver.cs	Updates framework retrieval to use `Frameworks.TryGetFrameworks`.

rolfbjarne · 2026-06-02T15:47:26Z

/azp run

azure-pipelines · 2026-06-02T15:47:32Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

rolfbjarne · 2026-06-02T15:48:07Z

/azp run

azure-pipelines · 2026-06-02T15:48:38Z

Azure Pipelines successfully started running 3 pipeline(s).

rolfbjarne · 2026-06-02T15:54:25Z

/azp run

azure-pipelines · 2026-06-02T15:54:54Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

+				catalyst_frameworks = iOSFrameworks;
+				// We're going to mutate the value returned from iOSFrameworks, so clear the cached value so the next time iOSFrameworks is called it's re-generated.
+				ios_frameworks = null;
+				// not present in iOS but present in catalyst
+				catalyst_frameworks.Add ("CoreWlan", "CoreWLAN", 15, 0);


+	public static bool TryGetFrameworks (ApplePlatform platform, [NotNullWhen (true)] out Frameworks? frameworks)
 	{
 		switch (platform) {
 		case ApplePlatform.iOS:
-			return GetiOSFrameworks (is_simulator_build);
+			frameworks = iOSFrameworks;


rolfbjarne · 2026-06-04T13:05:37Z

/azp run

azure-pipelines · 2026-06-04T13:06:09Z

Azure Pipelines successfully started running 3 pipeline(s).

rolfbjarne · 2026-06-05T08:31:06Z

/azp run

azure-pipelines · 2026-06-05T08:31:36Z

Azure Pipelines successfully started running 3 pipeline(s).

vs-mobiletools-engineering-service2 · 2026-06-05T08:48:14Z

✅ [PR Build #58a293a] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 58a293a50974c37d7a18b9b4ba13de04d31efd5e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-05T08:53:06Z

✅ [PR Build #58a293a] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 58a293a50974c37d7a18b9b4ba13de04d31efd5e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-05T09:00:07Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 58a293a50974c37d7a18b9b4ba13de04d31efd5e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-05T09:07:46Z

✅ [PR Build #58a293a] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 58a293a50974c37d7a18b9b4ba13de04d31efd5e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-05T16:17:46Z

🔥 [CI Build #58a293a] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 6 tests failed, 187 tests passed.

Failures

❌ introspection tests [attempt 2]

4 tests failed, 2 tests passed.

Failed tests

introspection/iOS - simulator/Debug: LaunchTimedOut
introspection/iOS - simulator/Debug (ARM64): LaunchTimedOut
introspection/tvOS - simulator/Debug: LaunchTimedOut
introspection/tvOS - simulator/Debug (ARM64): LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests (macOS) [attempt 2]

2 tests failed, 21 tests passed.

Failed tests

monotouch-test/macOS/Release (link sdk): TimedOut (Execution timed out after 1200 seconds.
Test run crashed)
monotouch-test/macOS/Release (NativeAOT): TimedOut (Execution timed out after 1200 seconds.
Test run crashed)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 23 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 20 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. [attempt 2] Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 58a293a50974c37d7a18b9b4ba13de04d31efd5e [PR build]

Copilot AI review requested due to automatic review settings June 2, 2026 15:15

Copilot started reviewing on behalf of rolfbjarne June 2, 2026 15:15 View session

Copilot AI reviewed Jun 2, 2026

View reviewed changes

Comment thread tools/common/Frameworks.cs

Comment thread tools/common/Frameworks.cs

Fix build.

2101920

Avoid cache poisoning.

f28f7d7

rolfbjarne requested a review from Copilot June 2, 2026 15:54

Copilot started reviewing on behalf of rolfbjarne June 2, 2026 15:54 View session

Copilot AI reviewed Jun 2, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jun 2, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/framework-info

5a5bd42

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/framework-info

58a293a

This comment has been minimized.

Sign in to view

Conversation

rolfbjarne commented Jun 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

rolfbjarne commented Jun 2, 2026

Uh oh!

azure-pipelines Bot commented Jun 2, 2026

Uh oh!

rolfbjarne commented Jun 2, 2026

Uh oh!

azure-pipelines Bot commented Jun 2, 2026

Uh oh!

rolfbjarne commented Jun 2, 2026

Uh oh!

azure-pipelines Bot commented Jun 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jun 5, 2026

Uh oh!

azure-pipelines Bot commented Jun 5, 2026

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 5, 2026

✅ [PR Build #58a293a] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 5, 2026

✅ [PR Build #58a293a] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 5, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 5, 2026

✅ [PR Build #58a293a] Build passed (Build macOS tests) ✅

Uh oh!