Update uselagoon/mysql-8.4 Docker tag to v26.3.0#157
Conversation
AlexSkrypnyk
added
the
Dependencies
📝 WalkthroughWalkthroughUpdated the MySQL 8.4 Docker image version from 26.2.0 to 26.3.0 in the database service build configuration within docker-compose.yml, maintaining all other service parameters and override behavior. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docker-compose.yml`:
- Line 160: The inline comment on the IMAGE environment variable line (IMAGE:
"${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if
defined) or fallback to standard database image.) has only one space before the
comment which fails yamllint; update the line in docker-compose.yml so there are
two spaces before the inline comment (i.e., ensure IMAGE: "...:26.3.0}"␣␣# Use
custom database image...) to satisfy the 2-space rule while leaving the value
and comment text unchanged.
- Line 160: The .docker/database.dockerfile must be updated so its MySQL image
tag matches docker-compose.yml's VORTEX_DB_IMAGE default
(uselagoon/mysql-8.4:26.3.0); locate the Dockerfile's base image/ARG that
currently references 26.2.0 (the value at the top of
.docker/database.dockerfile) and change that tag to 26.3.0 so independent builds
use the same MySQL version as the docker-compose default.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d080d4fc-fd94-47e0-bed2-53683f893cdf
📒 Files selected for processing (1)
docker-compose.yml
| dockerfile: .docker/database.dockerfile | ||
| args: | ||
| IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.2.0}" # Use custom database image (if defined) or fallback to standard database image. | ||
| IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if defined) or fallback to standard database image. |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Add proper spacing before inline comment.
YAMLlint expects 2 spaces before inline comments. The current line has only 1 space before the comment.
✨ Proposed formatting fix
- IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if defined) or fallback to standard database image.
+ IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if defined) or fallback to standard database image.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if defined) or fallback to standard database image. | |
| IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if defined) or fallback to standard database image. |
🧰 Tools
🪛 YAMLlint (1.38.0)
[warning] 160-160: too few spaces before comment: expected 2
(comments)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docker-compose.yml` at line 160, The inline comment on the IMAGE environment
variable line (IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use
custom database image (if defined) or fallback to standard database image.) has
only one space before the comment which fails yamllint; update the line in
docker-compose.yml so there are two spaces before the inline comment (i.e.,
ensure IMAGE: "...:26.3.0}"␣␣# Use custom database image...) to satisfy the
2-space rule while leaving the value and comment text unchanged.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find all references to MySQL 8.4 version 26.2.0 in the codebase
# Search for version 26.2.0 in relation to mysql-8.4
rg -n 'mysql-8\.4.*26\.2\.0|26\.2\.0.*mysql-8\.4' --type yaml --type dockerfile
# Also check for any version references in Dockerfiles
fd -e dockerfile -x rg -l '26\.2\.0' {}Repository: drevops/website
Length of output: 93
🏁 Script executed:
#!/bin/bash
# Find the actual lines mentioned in the review
echo "=== Checking docker-compose.yml line 160 ==="
sed -n '155,165p' docker-compose.yml
echo ""
echo "=== Checking .docker/database.dockerfile ==="
if [ -f ".docker/database.dockerfile" ]; then
head -20 .docker/database.dockerfile
else
echo "File not found, searching for dockerfile..."
find . -name "*database.dockerfile*" -o -name "database.Dockerfile" | head -5
fi
echo ""
echo "=== Searching for 26.2.0 references ==="
rg '26\.2\.0' -g '*.yml' -g '*.yaml' -g '*.dockerfile' -g 'Dockerfile*'
echo ""
echo "=== Searching for 26.3.0 references ==="
rg '26\.3\.0' -g '*.yml' -g '*.yaml' -g '*.dockerfile' -g 'Dockerfile*'Repository: drevops/website
Length of output: 1406
Update .docker/database.dockerfile to match the docker-compose.yml MySQL version.
The docker-compose.yml specifies MySQL version 26.3.0 at line 160, but .docker/database.dockerfile still defaults to 26.2.0 at line 8. This creates environment drift when the Dockerfile is built independently of docker-compose (e.g., direct Docker builds or CI pipelines that don't use docker-compose).
Update line 8 in .docker/database.dockerfile:
-ARG IMAGE=uselagoon/mysql-8.4:26.2.0
+ARG IMAGE=uselagoon/mysql-8.4:26.3.0🧰 Tools
🪛 YAMLlint (1.38.0)
[warning] 160-160: too few spaces before comment: expected 2
(comments)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docker-compose.yml` at line 160, The .docker/database.dockerfile must be
updated so its MySQL image tag matches docker-compose.yml's VORTEX_DB_IMAGE
default (uselagoon/mysql-8.4:26.3.0); locate the Dockerfile's base image/ARG
that currently references 26.2.0 (the value at the top of
.docker/database.dockerfile) and change that tag to 26.3.0 so independent builds
use the same MySQL version as the docker-compose default.
|
Code coverage (GitHub Actions) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #157 +/- ##
========================================
Coverage 87.73% 87.73%
========================================
Files 11 11
Lines 163 163
========================================
Hits 143 143
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
2 participants
This PR contains the following updates:
26.2.0->26.3.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
uselagoon/lagoon-images (uselagoon/mysql-8.4)
v26.3.0Compare Source
Notes on this release
This release introduces a new Solr 10 image (non-Drupal) and addresses Makefile auto-detection issues for users on Apple Silicon. We have also streamlined our scanning scripts by removing the Trivy results display and updated a wide range of runtime, database, and DevOps dependencies.
New Images
Deprecated Images
No images were deprecated in this release.
Removed Images
No images were removed in this release.
General changes
Package Updates
PHP related
Foundations
Databases / Caches / Search
Web / Runtime bases
Devops
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.
Summary by CodeRabbit