Skip to content

Update uselagoon/mysql-8.4 Docker tag to v26.3.0 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexSkrypnyk merged 1 commit into from
Mar 26, 2026
Merged

Update uselagoon/mysql-8.4 Docker tag to v26.3.0 #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ services:
context: .
dockerfile: .docker/database.dockerfile
args:
IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.2.0}" # Use custom database image (if defined) or fallback to standard database image.
IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if defined) or fallback to standard database image.
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Add proper spacing before inline comment.

YAMLlint expects 2 spaces before inline comments. The current line has only 1 space before the comment.

✨ Proposed formatting fix 
-        IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if defined) or fallback to standard database image.
+        IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}"  # Use custom database image (if defined) or fallback to standard database image.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if defined) or fallback to standard database image.
IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use custom database image (if defined) or fallback to standard database image.
🧰 Tools
🪛 YAMLlint (1.38.0)

[warning] 160-160: too few spaces before comment: expected 2

(comments)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@docker-compose.yml` at line 160, The inline comment on the IMAGE environment
variable line (IMAGE: "${VORTEX_DB_IMAGE:-uselagoon/mysql-8.4:26.3.0}" # Use
custom database image (if defined) or fallback to standard database image.) has
only one space before the comment which fails yamllint; update the line in
docker-compose.yml so there are two spaces before the inline comment (i.e.,
ensure IMAGE: "...:26.3.0}"␣␣# Use custom database image...) to satisfy the
2-space rule while leaving the value and comment text unchanged.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Find all references to MySQL 8.4 version 26.2.0 in the codebase

# Search for version 26.2.0 in relation to mysql-8.4
rg -n 'mysql-8\.4.*26\.2\.0|26\.2\.0.*mysql-8\.4' --type yaml --type dockerfile

# Also check for any version references in Dockerfiles
fd -e dockerfile -x rg -l '26\.2\.0' {}

Repository: drevops/website

Length of output: 93

🏁 Script executed:

#!/bin/bash
# Find the actual lines mentioned in the review

echo "=== Checking docker-compose.yml line 160 ==="
sed -n '155,165p' docker-compose.yml

echo ""
echo "=== Checking .docker/database.dockerfile ==="
if [ -f ".docker/database.dockerfile" ]; then
  head -20 .docker/database.dockerfile
else
  echo "File not found, searching for dockerfile..."
  find . -name "*database.dockerfile*" -o -name "database.Dockerfile" | head -5
fi

echo ""
echo "=== Searching for 26.2.0 references ==="
rg '26\.2\.0' -g '*.yml' -g '*.yaml' -g '*.dockerfile' -g 'Dockerfile*'

echo ""
echo "=== Searching for 26.3.0 references ==="
rg '26\.3\.0' -g '*.yml' -g '*.yaml' -g '*.dockerfile' -g 'Dockerfile*'

Repository: drevops/website

Length of output: 1406

Update .docker/database.dockerfile to match the docker-compose.yml MySQL version.

The docker-compose.yml specifies MySQL version 26.3.0 at line 160, but .docker/database.dockerfile still defaults to 26.2.0 at line 8. This creates environment drift when the Dockerfile is built independently of docker-compose (e.g., direct Docker builds or CI pipelines that don't use docker-compose).

Update line 8 in .docker/database.dockerfile:

-ARG IMAGE=uselagoon/mysql-8.4:26.2.0
+ARG IMAGE=uselagoon/mysql-8.4:26.3.0
🧰 Tools
🪛 YAMLlint (1.38.0)

[warning] 160-160: too few spaces before comment: expected 2

(comments)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@docker-compose.yml` at line 160, The .docker/database.dockerfile must be
updated so its MySQL image tag matches docker-compose.yml's VORTEX_DB_IMAGE
default (uselagoon/mysql-8.4:26.3.0); locate the Dockerfile's base image/ARG
that currently references 26.2.0 (the value at the top of
.docker/database.dockerfile) and change that tag to 26.3.0 so independent builds
use the same MySQL version as the docker-compose default.

environment:
<<: *default-environment
<<: *default-user
Expand Down
Loading